Differential D12389

Filepicker reads thumbs preview from Dolphin settings
ClosedPublic
Actions

Authored by anemeth on Apr 20 2018, 8:18 PM.

Details

Reviewers
ngraham
Group Reviewers
Frameworks
VDG
Dolphin
Maniphest Tasks
T8552: Polish Open/Save dialogs
Commits
R241:b9a2ec685e7f: Filepicker reads thumbs preview from Dolphin settings
Summary

Open/Save dialog uses the settings from Dolphin to determine what to show in the thumbnails.
Also now supports much more file types.

BUG: 318493

Test Plan

Diff Detail

Repository
R241 KIO
Branch
dolphin_thumbs (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
anemeth created this revision.Apr 20 2018, 8:18 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 20 2018, 8:18 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
anemeth requested review of this revision.Apr 20 2018, 8:18 PM
anemeth edited the summary of this revision. (Show Details)Apr 20 2018, 8:19 PM
anemeth edited the test plan for this revision. (Show Details)
anemeth added reviewers: Frameworks, VDG.
anemeth edited the summary of this revision. (Show Details)
anemeth added a subscriber: ngraham.
ngraham accepted this revision.Apr 20 2018, 11:05 PM
ngraham added a reviewer: Dolphin.

Wow, a truly trivial fix! Since Dolphin is currently where the config UI for this lives, I think it makes sense to re-use that information here.

I was worried about the use cases where Dolphin isn't installed (e.g. the case of someone using Kate or Gwenview or something in their GNOME or MATE environment) but I tested that out that seems to work just fine, and it gets the correct set of default plugins. Also works fine in the new user use case where Dolphin is installed, but the user opens a file dialog before Dolphin.

Dolphin folks, does this look sane?

This revision is now accepted and ready to land.Apr 20 2018, 11:05 PM
alexeymin added a subscriber: alexeymin.Apr 21 2018, 1:53 PM

Stupid question, what happens if dolphin is not installed?

ngraham added a comment.Apr 21 2018, 1:54 PM
In D12389#250931, @alexeymin wrote:

Stupid question, what happens if dolphin is not installed?

I answered that in the comment above yours. :) KConfig seems to handle it without issue. But test it out and see for yourself!

elvisangelaccio added a subscriber: elvisangelaccio.Apr 22 2018, 3:21 PM

+1

One more reason to move this stuff from the Dolphin settings into a KCM...

ngraham closed this revision.Apr 22 2018, 5:18 PM

Revision Contents
Changeset List

Diff 32676

View Options

src/filewidgets/kfilepreviewgenerator.cpp

Loading...