In Short View, display icons on top and increase icon size
AbandonedPublic

Authored by ngraham on Apr 18 2018, 7:44 PM.

Details

Reviewers
None
Summary

This patch increases the default size of the icons in Short View to 64px, to facilitate using them along with previews to see the content of predominately visual files. This patch makes Short View usable by default as the preferred mode for finding visual content.

For content that is best found via filename or metadata, or for long lists, Detailed Tree View is a better view, and D12077: Show view mode buttons in the open/save dialog's toolbar makes it easy to switch.

This patch has many prerequisites before it makes sense:

Depends on D12306
Depends on D12328
Depends on D12358
Depends on D12360

BUG: 86838
FIXED-IN: 5.46

Test Plan

[video will go here]

Diff Detail

Repository
R241 KIO
Branch
short-view-has-icons-on-top-by-default (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham created this revision.Apr 18 2018, 7:44 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 18 2018, 7:44 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
ngraham requested review of this revision.Apr 18 2018, 7:44 PM
anemeth added inline comments.
src/filewidgets/kdiroperator.cpp
2605

What is the relation between 43 and 64px?
Does this hardcoded number also work when scaled?

ngraham added inline comments.Apr 18 2018, 7:54 PM
src/filewidgets/kdiroperator.cpp
2605

The number is a 0-100 scale, with 0 corresponding to 16px, and 100 corresponding to 128px, and all other numbers corresponding to in-between sized along that same linear scale. It's a bit odd, and not the way I would have implemented it, but that's what we've got, so I decided to work with it and just add comments to improve the comprehensibility.

And yeah, it works fine with a HiDPI scale factor.

ngraham updated this revision to Diff 32531.Apr 19 2018, 2:26 AM

Rebase on current master

ngraham edited the summary of this revision. (Show Details)Apr 19 2018, 4:31 AM
ngraham retitled this revision from [WIP/open dependencies] In Short View, display icons on top and increase icon size to In Short View, display icons on top and increase icon size.Apr 19 2018, 5:46 PM
ngraham edited the summary of this revision. (Show Details)
ngraham added a subscriber: abetts.
rkflx added a subscriber: rkflx.Apr 26 2018, 7:29 PM
ngraham abandoned this revision.May 21 2019, 1:22 PM
ngraham marked 2 inline comments as done.

Better-implemented in D21315

Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. · View Herald TranscriptMay 21 2019, 1:22 PM