D11566 is now in KDE Frameworks 5.45 so we can drop
QStyleOptionProgressBarV2.
Details
- Reviewers
hpereiradacosta broulik - Group Reviewers
Breeze - Commits
- R31:ad50781ec718: [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)?
Is it okay to bump minimum required version of KF(KF5FrameworkIntegration) to 5.45? Are there any policies on minimum versions? (except Qt)
@davidedmundson
@broulik
@ngraham
Do you have any objections to bumping minimum required version of KF5FrameworkIntegration?
We need at least KF 5.45 so KCapacityBar and co have QStyle::State_Horizontal set.
One noticeable user of KCapacityBar, for example, is Dolphin. It uses KCapacityBar to display space information.
This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.
Yes, it's master-only.
The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.
So, given that, should I bump version or leave this patch as is?
KF 5.47 will be released soon enough so I guess that's OK to ship the code as is. Am I right?