[kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin
ClosedPublic

Authored by zzag on Apr 16 2018, 8:13 PM.

Details

Summary

D11566 is now in KDE Frameworks 5.45 so we can drop
QStyleOptionProgressBarV2.

Diff Detail

Repository
R31 Breeze
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
zzag created this revision.Apr 16 2018, 8:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 16 2018, 8:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
zzag requested review of this revision.Apr 16 2018, 8:13 PM
This revision is now accepted and ready to land.Apr 17 2018, 9:55 AM

Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)?

zzag added a comment.EditedApr 17 2018, 11:00 AM

Don't you need to raise the requirement to a new Frameworks version, or #ifdefs if it's not possible (as it should probably be coordinated with the rest of the Plasma team)?

Is it okay to bump minimum required version of KF(KF5FrameworkIntegration) to 5.45? Are there any policies on minimum versions? (except Qt)

@davidedmundson
@broulik
@ngraham

Do you have any objections to bumping minimum required version of KF5FrameworkIntegration?

We need at least KF 5.45 so KCapacityBar and co have QStyle::State_Horizontal set.
One noticeable user of KCapacityBar, for example, is Dolphin. It uses KCapacityBar to display space information.

This is master-only code, right? The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.

zzag added a comment.Apr 17 2018, 1:21 PM

This is master-only code, right?

Yes, it's master-only.

The upcoming Plasma 5.13 will depend on KF 5.46 so this should be fine.

So, given that, should I bump version or leave this patch as is?

zzag added a comment.May 30 2018, 10:39 AM

KF 5.47 will be released soon enough so I guess that's OK to ship the code as is. Am I right?

zzag retitled this revision from [kstyle] drop QStyleOptionProgressBarV2 in Qt 5 style plugin to [kstyle] Drop QStyleOptionProgressBarV2 in Qt 5 style plugin.May 30 2018, 10:40 AM
broulik accepted this revision.Jun 7 2018, 1:20 PM
This revision was automatically updated to reflect the committed changes.