Support hidden NTFS files only on OS that support extended file attributes. For this purpose check if sys/xattr.h exist via CMake.
Details
- Reviewers
kossebau dfaure - Group Reviewers
Dolphin - Commits
- R241:f1ab805c4ebc: Fix build on FreeBSD broken by d7cce9937d5e9af2753fadb82d11f308b58bb8fa
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Thanks for coming up so quickly with a fix :)
You surely wanted to also wrap the include of the "sys/xattr.h" header in the new condition? Missing from the patch.
src/ioslaves/file/config-kioslave-file.h.cmake | ||
---|---|---|
16 | Please add a trailing newline to the end of the file. |
src/ioslaves/file/config-kioslave-file.h.cmake | ||
---|---|---|
14 | While FindACL.cmake sets internally the cmake variable HAVE_SYS_XATTR_H, it is not part of the officially set variables (cmp. notes in header of that file) So more future-proof will be to do an explicit check_include_files(sys/xattr.h HAVE_SYS_XATTR_H) in src/ioslaves/file/CMakeLists.txt instead of reyling on an undocumented side-effect of find_package(ACL). |
From quick pure code reading this looks fine to me. +1
Have not tested though right now, so have to leave the ship-it to actual Dolphin/KIO maintainers.
This change or an equivalent fix needs to be merged in relatively urgently as it is now creating a maintainability issue for the CI system.
As a consequence of the breakage the Dependency Builds are failing and they need to complete a successful run in order to restore the ability of the system to successfully build several projects.
Among those affected are KMyMoney and plasma-workspace.
As I have mentioned previously, Frameworks must always be kept in a buildable condition on all relevant platforms.