Added the option as we discussed.
Details
Details
- Reviewers
martinkostolny rade - Group Reviewers
Krusader - Commits
- R167:2364a0106dd4: Added Konfigurator option to control bookmark search bar visibility
Check if new option work as you expect it to work.
Diff Detail
Diff Detail
- Repository
- R167 Krusader
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good!
When looking through the menu I discovered a bug though but that is unrelated to this code.
Comment Actions
Works nicely, thanks!
krusader/BookMan/krbookmarkhandler.cpp | ||
---|---|---|
77–78 | Just a suggestion - add a placeholder: _quickSearchBar->setPlaceholderText(i18n("Type to search...")); |
Comment Actions
Rade, Martin, thanks for the review.
Martin, I included your suggestion into the final commit. I planned to do it and totally forgot about it. Thanks for the reminder!