Fixed key handling bug and added a QoL improvement

Authored by rade on Mar 22 2018, 6:04 AM.

Description

Fixed key handling bug and added a QoL improvement

Added code to filter both return and and escape keys.
Before this sometimes they would be added to the search string.
I.e opening the menu and then pressing return, and then typing 'ca'
would cause the return string to become '\rca'.
With no indication to the user of the inital '\r'.
This might only happen if no item is highlighted though.
Still filtering it is the right choice.

I also added a quality of life improvement, in the form of enabling
left arrow to close the menu. Before if you were three submenus deep
and wanted to exit you would have to press left arrow twice to close
the submenus, and then esc to close the main menu.
Now you can just hit left arrow three times.

Reviewed By: nmel, martinkostolny
Edited By: nmel

Differential Revision: https://phabricator.kde.org/D11523

Details

Committed
nmelMar 22 2018, 6:12 AM
Reviewer
nmel
Differential Revision
D11523: Key handling bug and a QoL improvement
Parents
R167:42858f0ea2c9: Improved match highlighting in the bookmark quick search
Branches
Unknown
Tags
Unknown