Differential D11538

Added Konfigurator option to control bookmark search bar visibility
ClosedPublic
Actions

Authored by nmel on Mar 21 2018, 6:47 AM.

Details

Reviewers
martinkostolny
rade
Group Reviewers
Krusader
Commits
R167:2364a0106dd4: Added Konfigurator option to control bookmark search bar visibility
Summary

Added the option as we discussed.

Test Plan

Check if new option work as you expect it to work.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nmel requested review of this revision.Mar 21 2018, 6:47 AM
nmel created this revision.
nmel added a project: Krusader.Mar 21 2018, 6:49 AM
nmel added reviewers: martinkostolny, rade.

As usual, apply on top of the bookmark-quicksearch branch.

rade accepted this revision.Mar 21 2018, 4:11 PM

Looks good!
When looking through the menu I discovered a bug though but that is unrelated to this code.

This revision is now accepted and ready to land.Mar 21 2018, 4:11 PM
martinkostolny accepted this revision.Mar 21 2018, 6:16 PM

Works nicely, thanks!

krusader/BookMan/krbookmarkhandler.cpp
77–78

Just a suggestion - add a placeholder:

_quickSearchBar->setPlaceholderText(i18n("Type to search..."));
nmel added a comment.Mar 22 2018, 6:36 AM
In D11538#230889, @rade wrote:

When looking through the menu I discovered a bug though but that is unrelated to this code.

It seems like Font Metrics is wrong. What kind of font is it?

Closed by commit R167:2364a0106dd4: Added Konfigurator option to control bookmark search bar visibility (authored by nmel). · Explain WhyMar 22 2018, 6:45 AM
This revision was automatically updated to reflect the committed changes.
nmel marked an inline comment as done.Mar 22 2018, 6:54 AM

Rade, Martin, thanks for the review.
Martin, I included your suggestion into the final commit. I planned to do it and totally forgot about it. Thanks for the reminder!

Revision Contents
Changeset List

Diff 30191

View Options

krusader/BookMan/krbookmarkhandler.cpp

Loading...
View Options

krusader/Konfigurator/kgpanel.cpp

Loading...