Remove frame around media action icons
ClosedPublic
Actions

Authored by romangg on Mar 5 2018, 10:48 AM.

Details

Reviewers

andreask
ngraham

Group Reviewers

Breeze
VDG

Commits

R266:106b27347125: Remove frame around media action icons

Summary

We were inconsistent on that and it can get in way with placement on buttons.

Also Research showed that many established media players do not per se feature
a frame around their media control buttons.

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Mar 5 2018, 10:48 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 5 2018, 10:48 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

romangg requested review of this revision.Mar 5 2018, 10:48 AM

romangg added reviewers: Breeze, VDG.Mar 5 2018, 10:49 AM

romangg added a dependent revision: D11050: Remove frames around media buttons.Mar 5 2018, 11:07 AM

as a pure code review, +1 from me as i see style="fill:currentColor;fill-opacity:1;stroke:none" remained inalterated so you did fix the mess inkscape likes to do with it :)

as style, i definitely like it more without circles around, final approval is by Andreas. (maybe add a couple of screenshots?)

romangg added a dependent revision: D11054: Add media status icons.Mar 5 2018, 1:05 PM

andreask accepted this revision.Mar 6 2018, 11:01 AM

This revision is now accepted and ready to land.Mar 6 2018, 11:01 AM

Looks good to me too!

Closed by commit R266:106b27347125: Remove frame around media action icons (authored by romangg). · Explain WhyMar 7 2018, 9:30 AM

This revision was automatically updated to reflect the committed changes.

astippich mentioned this in D10292: change 32px icons for playlist shuffle and repeat.Mar 9 2018, 6:40 PM

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/actions/16/media-playback-pause.svg (4 lines)
M			icons-dark/actions/16/media-playback-start.svg (4 lines)
M			icons-dark/actions/16/media-playback-stop.svg (4 lines)
M			icons-dark/actions/16/media-record.svg (6 lines)
M			icons-dark/actions/16/media-seek-backward.svg (4 lines)
M			icons-dark/actions/16/media-seek-forward.svg (4 lines)
M			icons-dark/actions/16/media-skip-backward.svg (4 lines)
M			icons-dark/actions/16/media-skip-forward.svg (4 lines)
M			icons-dark/actions/22/media-playback-pause.svg (8 lines)
M			icons-dark/actions/22/media-playback-start.svg (8 lines)
M			icons-dark/actions/22/media-playback-stop.svg (8 lines)
M			icons-dark/actions/22/media-seek-backward.svg (8 lines)
M			icons-dark/actions/22/media-seek-forward.svg (8 lines)
M			icons-dark/actions/22/media-skip-backward.svg (8 lines)
M			icons-dark/actions/22/media-skip-forward.svg (8 lines)
M			icons-dark/actions/24/media-playback-pause.svg (4 lines)
M			icons-dark/actions/24/media-playback-start.svg (4 lines)
M			icons-dark/actions/24/media-playback-stop.svg (4 lines)
M			icons-dark/actions/24/media-record.svg (11 lines)
M			icons-dark/actions/24/media-seek-backward.svg (4 lines)
M			icons-dark/actions/24/media-seek-forward.svg (4 lines)
M			icons-dark/actions/24/media-skip-backward.svg (4 lines)
M			icons-dark/actions/24/media-skip-forward.svg (4 lines)
M			icons-dark/actions/32/media-playback-pause.svg (6 lines)
M			icons-dark/actions/32/media-playback-start.svg (6 lines)
M			icons-dark/actions/32/media-playback-stop.svg (6 lines)
M			icons-dark/actions/32/media-record.svg (10 lines)
M			icons-dark/actions/32/media-seek-backward.svg (6 lines)
M			icons-dark/actions/32/media-seek-forward.svg (6 lines)
M			icons-dark/actions/32/media-skip-backward.svg (6 lines)
M			icons-dark/actions/32/media-skip-forward.svg (6 lines)
M			icons/actions/16/media-playback-pause.svg (4 lines)
M			icons/actions/16/media-playback-start.svg (4 lines)
M			icons/actions/16/media-playback-stop.svg (4 lines)
M			icons/actions/16/media-record.svg (6 lines)
M			icons/actions/16/media-seek-backward.svg (4 lines)
M			icons/actions/16/media-seek-forward.svg (4 lines)
M			icons/actions/16/media-skip-backward.svg (4 lines)
M			icons/actions/16/media-skip-forward.svg (4 lines)
M			icons/actions/22/media-playback-pause.svg (8 lines)
M			icons/actions/22/media-playback-start.svg (8 lines)
M			icons/actions/22/media-playback-stop.svg (8 lines)
M			icons/actions/22/media-seek-backward.svg (8 lines)
M			icons/actions/22/media-seek-forward.svg (8 lines)
M			icons/actions/22/media-skip-backward.svg (8 lines)
M			icons/actions/22/media-skip-forward.svg (8 lines)
M			icons/actions/24/media-playback-pause.svg (4 lines)
M			icons/actions/24/media-playback-start.svg (4 lines)
M			icons/actions/24/media-playback-stop.svg (4 lines)
M			icons/actions/24/media-record.svg (11 lines)
M			icons/actions/24/media-seek-backward.svg (4 lines)
M			icons/actions/24/media-seek-forward.svg (4 lines)
M			icons/actions/24/media-skip-backward.svg (4 lines)
M			icons/actions/24/media-skip-forward.svg (4 lines)
M			icons/actions/32/media-playback-pause.svg (6 lines)
M			icons/actions/32/media-playback-start.svg (6 lines)
M			icons/actions/32/media-playback-stop.svg (6 lines)
M			icons/actions/32/media-record.svg (8 lines)
M			icons/actions/32/media-seek-backward.svg (6 lines)
M			icons/actions/32/media-seek-forward.svg (6 lines)
M			icons/actions/32/media-skip-backward.svg (6 lines)
M			icons/actions/32/media-skip-forward.svg (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28689	eec9316		Mar 5 2018, 10:48 AM	★	★
Diff 2	28898	eec9316	R266:106b2734712597519ae5eeebb86f490c7f13ab26	Mar 7 2018, 9:30 AM	★	★

Status	Author	Revision
Closed	romangg	D11056 [mediacontroller applet] Use media playback status icons
Closed	romangg	D11054 Add media status icons
Closed	romangg	D11063 [mediacontroller applet] Reorder elements
Closed	romangg	D11050 Remove frames around media buttons
Closed	romangg	D11049 Remove frame around media action icons