change 32px icons for playlist shuffle and repeat

Authored by astippich on Feb 4 2018, 12:52 PM.



the 32px icons for media-playlist-shuffle and media-playlist-repeat look totally different than the icons with sizes <= 24px.
Also, they do not fit with the current design with their sharp corners. Change to the design of the smaller icons. Icons were created using a scaled version of the 24px icons.

Diff Detail

R266 Breeze Icons
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Feb 4 2018, 12:52 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 4 2018, 12:52 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
astippich requested review of this revision.Feb 4 2018, 12:52 PM


After, which is also how the 24px and lower icons look like:

Mouse cursors not included of course :)
Disclaimer: I'm in no way a graphic designer.

astippich edited the summary of this revision. (Show Details)Feb 4 2018, 12:57 PM
astippich updated this revision to Diff 26512.Feb 4 2018, 3:54 PM

update to 1px of line width, was 1.5 due to the scaling

ngraham added a subscriber: ngraham.Feb 4 2018, 4:12 PM
andreask requested changes to this revision.Feb 19 2018, 10:27 PM
andreask added a subscriber: andreask.

only in 16px there is no circle and in general I'm not really happy to have no circle around the icon. maybe for repeat and shuffle it will work but play/pause are more intuitive with circle than without.

This revision now requires changes to proceed.Feb 19 2018, 10:27 PM

Thanks for the feedback!
So the correct fix would be to change the 22px and 24px icons to use circles around the icons?

astippich updated this revision to Diff 29110.Mar 9 2018, 6:36 PM
  • add more 32px icons

after D11049 where the frames for the media buttons were removed I think this is quite needed for a consistent look and feel. I also added 32px version for no repeat and no shuffle which I need for a toggle button for Elisa

This comment was removed by ngraham.
ngraham accepted this revision.Mar 9 2018, 8:23 PM

Agreed. They look great to me!

Can I land this? phabricator doesn't show it as accepted though

It is currently pending on @andreask reviewing it, as they have previously requested changes.

It also needs @andreaska to review it (not sure if this is correct?)

Phabricator only considers something ready for landing once all reviewers have approved it.

andreask accepted this revision.Mar 28 2018, 9:00 PM

sorry for the late approve.

This revision is now accepted and ready to land.Mar 28 2018, 9:00 PM

Thanks a lot!

This revision was automatically updated to reflect the committed changes.