Differential D10823

idutils: Fix typo
ClosedPublic
Actions

Authored by michaelh on Feb 25 2018, 10:53 AM.

Details

Reviewers
adridg
alexeymin
Group Reviewers
Baloo
Frameworks
Commits
R293:fa08a62b0fdf: idutils: Fix typo

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh requested review of this revision.Feb 25 2018, 10:53 AM
michaelh created this revision.

Let's start slowly

alexeymin added a subscriber: alexeymin.Feb 25 2018, 11:02 AM

Maybe such kinds of changes can be committed without review? ;)

alexeymin accepted this revision.Feb 25 2018, 11:04 AM
This revision is now accepted and ready to land.Feb 25 2018, 11:04 AM
michaelh added a comment.Feb 25 2018, 11:27 AM
In D10823#213409, @alexeymin wrote:

Maybe such kinds of changes can be committed without review? ;)

This is to make @adridg happy. The real fun starts, when you take a look at the stack of this.

I need to be sure: arc land will push this to the flexible-docid branch?

adridg accepted this revision.Feb 25 2018, 12:33 PM

I'm so happy :)

This is partly to help @michaelh get into the swing of things, with writing a patch, pushing it to review, getting it okayed .. a bit of "this is the process". Of course later there's no need for typo-fix reviews that don't affect user-visible strings.

As for landing in the right branch .. er .. to me that's arcane (ha!) knowledge. I would suggest landing this one, and then you can see where it ends up :)

Closed by commit R293:fa08a62b0fdf: idutils: Fix typo (authored by michaelh). · Explain WhyFeb 25 2018, 1:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/engine/idutils.h (2 lines)

Diff 28027

View Options

src/engine/idutils.h

Loading...