[WIP] Make tests compile, except one
Changes PlannedPublic

Authored by michaelh on Feb 26 2018, 11:37 AM.

Details

Reviewers
adridg
Group Reviewers
Baloo
Frameworks
Test Plan

make test

Diff Detail

Repository
R293 Baloo
Branch
use-class-tests-compile (branched from flexible-docid)
Lint
No Linters Available
Unit
No Unit Test Coverage
michaelh created this revision.Feb 26 2018, 11:37 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 26 2018, 11:37 AM
michaelh requested review of this revision.Feb 26 2018, 11:37 AM
michaelh added inline comments.Feb 26 2018, 11:48 AM
src/file/extractor/autotests/iohandlertest.cpp
32

Error is:

[ 34%] Linking CXX executable ../../../../bin/extractorIOTest
CMakeFiles/extractorIOTest.dir/iohandlertest.cpp.o: In function `Baloo::IOHandlerTest::testInput()':
~/src/frameworks/baloo-flex/src/file/extractor/autotests/iohandlertest.cpp:72: undefined reference to `Baloo::DocumentId::~DocumentId()'
CMakeFiles/extractorIOTest.dir/iohandlertest.cpp.o: In function `bool QTest::qCompare<Baloo::DocumentId, unsigned long long>(Baloo::DocumentId const&, unsigned long long const&, char const*, char const*, char const*, int)':
/usr/include/qt5/QtTest/qtestcase.h:397: undefined reference to `Baloo::DocumentId::operator unsigned long long() const'
CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o: In function `Baloo::IOHandler::nextId()':
~/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:47: undefined reference to `Baloo::DocumentId::DocumentId(unsigned long long)'
~/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:50: undefined reference to `Baloo::DocumentId::operator unsigned long long() const'
collect2: error: ld returned 1 exit status

fileextractor is special. It is a daemon and not part of the lib.

michaelh planned changes to this revision.Feb 26 2018, 4:39 PM
michaelh retitled this revision from Make tests compile, except one to [WIP] Make tests compile, except one.Feb 28 2018, 9:59 AM
Restricted Application added a project: Baloo. · View Herald TranscriptFeb 28 2018, 9:59 AM

This looks abandoned, no movement in over two years. @michaelh did you still want to introduce docId instead of quint64? This diff was supposed to supplant D10851 but seems to have fallen asleep as well. (In retrospect, perhaps I would have suggested first introducing just using docId = quint64; somewhere, to get the more-expressive-type-name part out of the way before real changes)

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 30 2020, 3:50 PM