[WIP] Introduce aliases DocId, DeviceId and Inode
Needs ReviewPublic
Actions

Authored by michaelh on Feb 25 2018, 10:58 AM.

Details

Reviewers

Group Reviewers

Baloo
Frameworks

Summary

This is the first step of porting away from using quint64 as Document id
and turning it into a class.

It is done by find/replace quint64 and adding #include "idutils.h" until it compiled

Test Plan

make test

Diff Detail

Repository

R293 Baloo

Branch

aliases (branched from flexible-docid)

Lint

No Linters Available

Unit

No Unit Test Coverage

michaelh created this revision.Feb 25 2018, 10:58 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 25 2018, 10:58 AM

michaelh requested review of this revision.Feb 25 2018, 10:58 AM

michaelh added a dependency: D10823: idutils: Fix typo.

michaelh added a dependent revision: D10826: [WIP] Introduce DocumentId class.Feb 25 2018, 11:11 AM

This gives a bunch of warnings like

src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    return *(reinterpret-cast<DocId*>(arr));

Were these before...?

In D10825#213478, @alexeymin wrote:
This gives a bunch of warnings like
src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
     return *(reinterpret-cast<DocId*>(arr));
Were these before...?

I haven't seen those. I wouldn't have submitted it otherwise. I'll have a look, what this means.

michaelh added inline comments.Feb 25 2018, 11:39 AM

src/engine/idutils.h
49	@alexeymin: This will become return DocumentId(devId, inode); The warning should be gone after that.

Nice job, looks good. No compilation warnings for me, no test failures, and all functionality that I tested still works. I found a few minor formatting issues; see the below comments.

src/engine/idtreedb.cpp
80	Unintentional indentation?
src/file/extractor/result.h
44	Can we `#include "idutils.h"` on this file too, so we don't have to use the `Baloo::` namespace prefix here and in the implementation file?
src/tools/balooshow/main.cpp
114	Ditto.

@alexeymin , @ngraham: I asked IRC:kdevelop how to turn -Wstrict-aliasing on and was pointed to cmake docs. If this setting is defined in one of the cmake-files, why do they differ? Could it be an internal setting of the IDE? I'm using KDevelop and there seems to be no option to switch that on.

src/engine/idtreedb.cpp
80	I wonder how that came about.

Merge branch 'flexible-docid' of git://anongit.kde.org/baloo into aliases
Correct indentation

michaelh mentioned this in D10851: autotests: Introduce alias DocId.Feb 26 2018, 7:57 AM

michaelh added a dependent revision: D10851: autotests: Introduce alias DocId.Feb 26 2018, 8:06 AM

michaelh retitled this revision from Introduce aliases DocId, DeviceId and Inode to [WIP] Introduce aliases DocId, DeviceId and Inode.Feb 28 2018, 9:58 AM

This looks abandoned with 2 years of no movement. @michaelh do you still feel this is a WIP?

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald TranscriptMay 30 2020, 3:53 PM

Revision Contents
Changeset List

			Path	Packages
M			src/codecs/coding.h (8 lines)
M			src/codecs/positioncodec.cpp (2 lines)
M			src/codecs/postingcodec.h (6 lines)
M			src/codecs/postingcodec.cpp (12 lines)
M			src/engine/andpostingiterator.h (6 lines)
M			src/engine/andpostingiterator.cpp (4 lines)
M			src/engine/document.h (8 lines)
M			src/engine/document.cpp (4 lines)
M			src/engine/documentdatadb.h (11 lines)
M			src/engine/documentdatadb.cpp (22 lines)
M			src/engine/documentdb.h (11 lines)
M			src/engine/documentdb.cpp (22 lines)
M			src/engine/documentiddb.h (11 lines)
M			src/engine/documentiddb.cpp (24 lines)
M			src/engine/documenttimedb.h (11 lines)
M			src/engine/documenttimedb.cpp (22 lines)
M			src/engine/documenturldb.h (28 lines)
M			src/engine/documenturldb.cpp (44 lines)
M			src/engine/idfilenamedb.h (13 lines)
M			src/engine/idfilenamedb.cpp (26 lines)
M			src/engine/idtreedb.h (11 lines)
M			src/engine/idtreedb.cpp (45 lines)
M			src/engine/idutils.h (19 lines)
M			src/engine/mtimedb.h (9 lines)
M			src/engine/mtimedb.cpp (36 lines)
M			src/engine/orpostingiterator.h (6 lines)
M			src/engine/orpostingiterator.cpp (4 lines)
M			src/engine/phraseanditerator.h (6 lines)
M			src/engine/phraseanditerator.cpp (4 lines)
M			src/engine/positiondb.cpp (4 lines)
M			src/engine/positioninfo.h (6 lines)
M			src/engine/postingdb.h (2 lines)
M			src/engine/postingdb.cpp (10 lines)
M			src/engine/postingiterator.h (7 lines)
M			src/engine/postingiterator.cpp (2 lines)
M			src/engine/transaction.h (38 lines)
M			src/engine/transaction.cpp (54 lines)
M			src/engine/vectorpositioninfoiterator.h (4 lines)
M			src/engine/vectorpositioninfoiterator.cpp (4 lines)
M			src/engine/vectorpostingiterator.h (8 lines)
M			src/engine/vectorpostingiterator.cpp (6 lines)
M			src/engine/writetransaction.h (18 lines)
M			src/engine/writetransaction.cpp (24 lines)
M			src/file/extractor/app.h (3 lines)
M			src/file/extractor/app.cpp (6 lines)
M			src/file/extractor/autotests/iohandlertest.cpp (8 lines)
M			src/file/extractor/iohandler.h (4 lines)
M			src/file/extractor/iohandler.cpp (6 lines)
M			src/file/extractor/result.h (7 lines)
M			src/file/extractor/result.cpp (2 lines)
M			src/file/extractorprocess.h (4 lines)
M			src/file/extractorprocess.cpp (6 lines)
M			src/file/filecontentindexer.cpp (2 lines)
M			src/file/filecontentindexerprovider.h (4 lines)
M			src/file/filecontentindexerprovider.cpp (2 lines)
M			src/file/indexcleaner.cpp (4 lines)
M			src/file/metadatamover.cpp (4 lines)
M			src/file/modifiedfileindexer.cpp (2 lines)
M			src/file/unindexedfileindexer.cpp (2 lines)
M			src/file/unindexedfileiterator.cpp (2 lines)
M			src/lib/file.cpp (2 lines)
M			src/lib/searchstore.cpp (12 lines)
M			src/tools/balooctl/main.cpp (4 lines)
M			src/tools/balooctl/statuscommand.cpp (6 lines)
M			src/tools/balooshow/main.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28001	0c89b89		Feb 25 2018, 10:55 AM	★	★
Diff 2	28088	fa08a62	- Merge branch 'flexible-docid' of git://anongit.kde.org/baloo into aliases	Feb 26 2018, 7:11 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
c2e79ce67d61	b21fbeda3233	447fcd43331c	Michael Heidelbach	Correct indentation	Feb 26 2018, 7:04 AM
447fcd43331c	9ce09f320cba	498a3914d1ea fa08a62b0fdf	Michael Heidelbach	Merge branch 'flexible-docid' of git://anongit.kde.org/baloo into aliases	Feb 25 2018, 1:27 PM
498a3914d1ea	9ce09f320cba	287f53c1b7b5 0c89b89bf483	Michael Heidelbach	Merge branch 'typo' into aliases	Feb 25 2018, 8:12 AM
0c89b89bf483	ff3cd832f8da	70162de9741e	Michael Heidelbach	idutils: Fix typo	Feb 25 2018, 8:07 AM
287f53c1b7b5	33100c9b1db2	70162de9741e	Michael Heidelbach	Introduce aliases DocId, DeviceId and Inode (Show More…)	Feb 23 2018, 8:19 PM

Status	Author	Revision
Changes Planned	michaelh	D10856 [WIP] Make tests compile, except one
Changes Planned	michaelh	D10829 [WIP] Use DocumentId class
Needs Review	michaelh	D10826 [WIP] Introduce DocumentId class
Needs Review	michaelh	D10851 autotests: Introduce alias DocId
Needs Review	michaelh	D10825 [WIP] Introduce aliases DocId, DeviceId and Inode
Closed	michaelh	D10823 idutils: Fix typo

[WIP] Introduce aliases DocId, DeviceId and InodeNeeds ReviewPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 28088

src/codecs/coding.h

src/codecs/positioncodec.cpp

src/codecs/postingcodec.h

src/codecs/postingcodec.cpp

src/engine/andpostingiterator.h

src/engine/andpostingiterator.cpp

src/engine/document.h

src/engine/document.cpp

src/engine/documentdatadb.h

src/engine/documentdatadb.cpp

src/engine/documentdb.h

src/engine/documentdb.cpp

src/engine/documentiddb.h

src/engine/documentiddb.cpp

src/engine/documenttimedb.h

src/engine/documenttimedb.cpp

src/engine/documenturldb.h

src/engine/documenturldb.cpp

src/engine/idfilenamedb.h

src/engine/idfilenamedb.cpp

src/engine/idtreedb.h

src/engine/idtreedb.cpp

src/engine/idutils.h

src/engine/mtimedb.h

src/engine/mtimedb.cpp

src/engine/orpostingiterator.h

src/engine/orpostingiterator.cpp

src/engine/phraseanditerator.h

src/engine/phraseanditerator.cpp

src/engine/positiondb.cpp

src/engine/positioninfo.h

src/engine/postingdb.h

src/engine/postingdb.cpp

src/engine/postingiterator.h

src/engine/postingiterator.cpp

src/engine/transaction.h

src/engine/transaction.cpp

src/engine/vectorpositioninfoiterator.h

src/engine/vectorpositioninfoiterator.cpp

src/engine/vectorpostingiterator.h

src/engine/vectorpostingiterator.cpp

src/engine/writetransaction.h

src/engine/writetransaction.cpp

src/file/extractor/app.h

src/file/extractor/app.cpp

src/file/extractor/autotests/iohandlertest.cpp

src/file/extractor/iohandler.h

src/file/extractor/iohandler.cpp

src/file/extractor/result.h

src/file/extractor/result.cpp

src/file/extractorprocess.h

src/file/extractorprocess.cpp

src/file/filecontentindexer.cpp

src/file/filecontentindexerprovider.h

src/file/filecontentindexerprovider.cpp

src/file/indexcleaner.cpp

src/file/metadatamover.cpp

src/file/modifiedfileindexer.cpp

src/file/unindexedfileindexer.cpp

src/file/unindexedfileiterator.cpp

src/lib/file.cpp

src/lib/searchstore.cpp

src/tools/balooctl/main.cpp

src/tools/balooctl/statuscommand.cpp

src/tools/balooshow/main.cpp

[WIP] Introduce aliases DocId, DeviceId and Inode
Needs ReviewPublic
Actions

Revision Contents
Changeset List