src/core/slavebase.cpp
154	This detaches (makes a copy of the list) because we're iterating over that same list. This should use iterators, with the usual it = container.remove(it) (or an algorithm, but this falls into the ugly erase(remove_if()) case). Cleaning up in a "has" method is a little unexpected anyway. Maybe it's simpler to make this one a find_if, and clean up elsewhere? Just a thought.
557–558	make that _V2, with << d->onHold rather than if(d->onHold), see other RR.

This revision now requires changes to proceed.Mar 1 2018, 7:06 AM

Added method updateTempAuthStatus() to take care of cleaning.
Rebased on D11010

anthonyfieroni added inline comments.

src/core/slavebase.cpp
155	it = m_tempAuths.erase(it); } else { ++it; }

dfaure requested changes to this revision.Mar 4 2018, 10:12 AM

dfaure added inline comments.

src/core/slavebase.cpp
151	This can't be a const_iterator, if you use it for erase()ing. I'm surprised this compiles...
162	const

This revision now requires changes to proceed.Mar 4 2018, 10:12 AM

src/core/slavebase.cpp
155	You forgot the `it =` in front.

Added the missing assignment

This revision is now accepted and ready to land.Mar 23 2018, 7:37 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			src/core/CMakeLists.txt (4 lines)
M			src/core/slavebase.cpp (27 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	27993	1ff8f3c		Feb 25 2018, 10:24 AM	★	★
Diff 2	28541	ec99750	Added method updateTempAuthStatus() to take care of cleaning.	Mar 4 2018, 6:21 AM	★	★
Diff 3	30332	e06080d	1. Made method const.	Mar 23 2018, 4:21 PM	★	★
Diff 4	30333	e06080d	Added the missing assignment	Mar 23 2018, 4:27 PM	★	★
Diff 5	31252	acccb63	R241:ea4329c36830cfceb0d82dadf7b49051c787355c	Apr 4 2018, 4:14 AM	★	★

Send slave's polkit authorization status to the host
ClosedPublic
Actions

Details