It will be used by klauncher to decide whether or not to kill the IdleSlave.
Depends on D10820
dfaure |
It will be used by klauncher to decide whether or not to kill the IdleSlave.
Depends on D10820
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
src/core/idleslave.cpp | ||
---|---|---|
80–81 | Reading tempAuth before url breaks protocol, i.e. people who upgrade KF5 in a running plasma session will be in big trouble. At least check if (!stream.atEnd()) before stream >> tempAuth. Hmm unfortunately that "last optional argument" URL breaks any possibility to make the change fully compatible :( How about this? Define MSG_SLAVE_STATUS_V2 which always sends all its arguments (including tempAuth, onHold, and url), and modify SlaveBase to send that, and support both here, at least temporarily? And this way in the future we don't need a V3, we can just append new arguments, with a atEnd() check. |
src/core/idleslave.cpp | ||
---|---|---|
70 | This could be made more runtime compatible by not rejecting MSG_SLAVE_STATUS completely, and handling it below (e.g. with a test on cmd at the right place, to still share the local variables). (That's what I meant by "support both here"). |
Thanks. Can you just add one comment, for the future?
src/core/idleslave.cpp | ||
---|---|---|
91 | // compat code for KF < 5.45. TODO KF6: remove |
Thanks (I just realized we need a similar comment next to the enum value MSG_SLAVE_STATUS though)