The Qt Xml module is not actively maintained anymore and docs suggest to use QXmlStreamReader.
This saves 3 ms startup time for Dolphin.
Details
Details
- Reviewers
davidedmundson apol - Group Reviewers
Frameworks
My devices still show up. In the original code is an isNull check for the element, is this something we should still have?
Diff Detail
Diff Detail
- Repository
- R245 Solid
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
These kinds of changes to Solid are going to need some *ahem* solid testing (I just kill myself sometimes) to avoid regressions, like the one we had in https://bugs.kde.org/show_bug.cgi?id=389479
Comment Actions
IMHO if we're fixing it, I'd go all-in and port from introspect to GetManagedObjects on the object manager.
You get rid of all XML parsing and you'd get the initial properties in the same call (instead of an additional one per iface)
You could even do all devices in one call with that.