CCBUG: 390527
Like D10558: Also use standard keyboard shortcut for "show/hide hidden files", but for the file dialogs too, to maintain consistency.
Details
Details
- Reviewers
elvisangelaccio markg - Group Reviewers
Frameworks Dolphin - Commits
- R241:164a54928e5e: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"
Tested with Open and Save dialogs in Kate. New and old shortcuts all worked and correctly triggered showing and hiding hidden files
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Fine by me.
I do wonder why it used to be in an if statement though. It would have added a nullptr if the "if (showHidden)" check failed (which would fail when it's a nullptr).
Comment Actions
The file dialog uses two different methods of setting shortcuts. Most are set in kdiroperator.cpp, but only few are set in kfilewidget.cpp I suspect legacy code, and it seems sensible to use the more standard, consistent style whenever possible.