Also use standard keyboard shortcut for "show/hide hidden files"
ClosedPublic

Authored by ngraham on Feb 15 2018, 9:30 PM.

Details

Summary

Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.

FEATURE: 390527
FIXED-IN: KDE Applications 17.12.3

Test Plan
  • Ctrl+H now shows and hides hidden files
  • Alt+. still works to do the same
  • F8 still works to do the same
  • Toolbar button still changes state appropriately when any of the three shortcuts are used

Diff Detail

Repository
R318 Dolphin
Branch
use-standard-show-hide-files-shortcut (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
ngraham requested review of this revision.Feb 15 2018, 9:30 PM
ngraham created this revision.
ngraham edited the summary of this revision. (Show Details)Feb 15 2018, 9:48 PM

This is a new feature so it should not got in the stable branch (unless we ask for an exception to the release team).

Other than that, +1 (are you planning to do the same for the file dialog?)

src/views/dolphinviewactionhandler.cpp
212

I'd put Alt+. first for historical reasons.

Thanks! I was thinking of putting Ctrl+H first because that's what people will see when they first go looking for the feature in the menus. This way, It will even look consistent across all Linux file managers, and consistency is good. People who already know Alt+. won't even notice the change because they're used to the keyboard shortcut. What do you think?

Yeah, I'll do the same thing for the file dialog too.

I'll ask the release team, but if we can't get an exception, that's fine, we'll just have to patch Dolphin in Kubuntu.

Thanks! I was thinking of putting Ctrl+H first because that's what people will see when they first go looking for the feature in the menus.

Well, either you already know the CTRL+H shortcut (and you will just use it), or you don't and you probably won't care about which shortcut will be visible in the menu.

This way, It will even look consistent across all Linux file managers, and consistency is good.

It will be consistent with GTK file managers, at most. What about macOS users? (they are used to CMD+Shift+.).
Also it's debatable whether CTRL+H should be considered the "standard" shortcut for hidden files. CTRL+H means "show history" in Web Browsers. Krusader uses it for the same purpose.

ngraham updated this revision to Diff 27410.Feb 17 2018, 4:39 PM

Reverse default shortcut order to restore Alt+. being the one shown in the menu

ngraham edited the test plan for this revision. (Show Details)Feb 17 2018, 4:40 PM
ngraham marked an inline comment as done.

Please ask release-team@kde.org whether we can ship this on 17.12

This revision is now accepted and ready to land.Feb 17 2018, 5:32 PM
ngraham edited the summary of this revision. (Show Details)Feb 17 2018, 8:28 PM

I have nothing pro or against CTRL+H as a shortcut, however perhaps I question a bit the need to have 3 different shortcuts to trigger the same action.

ngraham closed this revision.Feb 18 2018, 10:02 PM