No icons on the desktop by default
ClosedPublic

Authored by jriddell on Feb 16 2018, 4:28 PM.

Details

Summary

Don't add Home.desktop to links folder and don't add trash link.

Closes T7948

Test Plan

Start plasma as new user

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jriddell created this revision.Feb 16 2018, 4:28 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 16 2018, 4:28 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jriddell requested review of this revision.Feb 16 2018, 4:28 PM
jriddell retitled this revision from Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash link https://phabricator.kde.org/T7948 to Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948.Feb 16 2018, 4:28 PM
jriddell added a reviewer: Plasma.
In D10588#207890, @zzag wrote:

Why?

As discussed at 5.13 Kickoff meeting

mart added a subscriber: mart.Feb 20 2018, 2:21 PM

+1 from me

hein added a subscriber: hein.Feb 20 2018, 2:23 PM

I'll look into it, this week probably

See D10684 to make it easy for users to bring it back

zzag added a comment.Feb 20 2018, 3:39 PM

As discussed at 5.13 Kickoff meeting

I asked as an ordinary user. Could you please explain why Home and Trash icons should not be on the desktop by default?

These icons are very useful, especially trash icon. I don't have to open dolphin just to empty trash can.

Currently, it looks something like this, sorry

ngraham added a subscriber: ngraham.EditedFeb 20 2018, 4:03 PM

Memes aside, I have to agree. This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who like putting junk all over their desktop.

hein added a comment.EditedFeb 20 2018, 4:06 PM

This is just following up on a public promise we already made. When we turned Folder View into the default desktop containment, we told everyone (and got a lot of positive feedback from the users for it) that this means the desktop surface now supports icons by default again, but we don't actually place any by default so it's not having any impact on the people who prefer an empty desktop by default. Then it turns out we actually forgot to change the code.

zzag added a comment.Feb 20 2018, 4:28 PM

This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who like putting junk all over their desktop.

What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?

Also, someone could say: "It's Plasma, you can put trash icon back!"
The Trash can widget looks different from the default trash can icon + other folder icons(blurry, etc).

So, please, let home and trash icons stay on the desktop by default.

In D10588#210246, @zzag wrote:

This seems like the sort of things that developers prefer for "cleanliness", at the expense of messy ordinary users who like putting junk all over their desktop.

What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?

That's not changing.

hein added a comment.Feb 20 2018, 4:32 PM

This isn't about disabling support for icons (we just turned that back on in 5.10 ...), it's about not creating the Home and Trash icons by default on first login.

zzag added a comment.Feb 20 2018, 4:48 PM

This isn't about disabling support for icons (we just turned that back on in 5.10 ...), it's about not creating the Home and Trash icons by default on first login.

I'm talking about not creating home and trash icons by default.(not disabling folder view)

hein added a comment.Feb 20 2018, 4:58 PM

No, you weren't: "What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?"

zzag added a comment.EditedFeb 20 2018, 5:04 PM
In D10588#210276, @hein wrote:

No, you weren't: "What's the point of the desktop if it is not possible to place folder, pictures, music, etc on it?"

That was a rhetorical question, which apparently causes misunderstanding. Sorry.

hein accepted this revision.Feb 28 2018, 1:34 AM
This revision is now accepted and ready to land.Feb 28 2018, 1:34 AM
ngraham retitled this revision from Summary: No icons on the desktop by default. Dont add Home.desktop to links folder and dont add trash linkhttps://phabricator.kde.org/T7948 to No icons on the desktop by default.Feb 28 2018, 1:36 AM
ngraham edited the summary of this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.