This patch ports the core app away from kdelibs4support to pure qt5/kf5. Kdelibs4support classes that don't have an equivalent in qt5 or kf5 like KSharedPtr or KHBox were replaced by new ones (AmarokSharedPtr and BoxWidget).
There are also a lot of small fixes and changes in this patch, which I unfortunately cannot break off into their own revisions, because I lost my git history to a faulty hard drive and my only backup was months old. Sorry for that.
I also temporarily deactivated the tests. They get ported and reactivated in a later patch to keep the scope of this at least somewhat manageable. Also in later patches are a new qml context area with the most important applets, some services and importers. It's all finished and ready for merge as soon as this patch lands.
Details
- Reviewers
markey - Group Reviewers
Amarok - Commits
- R181:d78f666e58de: Port core application away from kdelibs4
Diff Detail
- Repository
- R181 Amarok
- Branch
- kf5
- Lint
No Linters Available - Unit
No Unit Test Coverage
Can I suggest we release 2.9 as planned, with the current state and maybe
some more bugfixes, before integrating this patch? Once migration to kf5 is
complete, and new patches will be needed for that, we may start thinking
about a 3.0.
The Amarok-KF5 development is in a different branch from master, so it's independent. Any work done in the KF5 branch has no influence on the KDE 4 Amarok code, so that could still be released.
! In D10526#207232, @markey wrote:
The Amarok-KF5 development is in a different branch from master, so it's independent. Any work done in the KF5 branch has no influence on the KDE 4 Amarok code, so that could still be released.
That. And even after merging it is possible to create kde4 branch from the commit just before merge and release from that branch.
But does it really make sense to release 2.9? Distributions have already started purging kdelibs based apps from their repos.
I guess this was really meant as '...away from kdelibs4support' instead of kdelibs4, hence the confusion. But yes it is targeting the correct branch.