Shouldn't this be controlled by System Settings > Application Style > Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels? Otherwise, people who check that setting will have a visible frame around the Places panel in Dolphin, but not in open/save file pickers, and will wonder why and file bugs about it.

Shouldn't this be controlled by System Settings > Application Style > Widget Style > Breeze > Configure > Frames > Draw Frame around Dockable panels?

If that option is enabled you get a frame even with this patch. Otherwise, the default, is nice and clean.

OK, great.

Why does it show the panel as if it were unlocked?
Your before image looks exactly like an unlocked frame in Dolphin.

Would it be possible to show it as if it were locked? That would solve all the issues with it, right?

Would it be possible to show it as if it were locked? That would solve all the issues with it, right?

I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly what I do here:

void DolphinDockWidget::setLocked(bool lock)
{
    ...
        if (lock) {
            ...
            setTitleBarWidget(m_dockTitleBar);
            setFeatures(QDockWidget::NoDockWidgetFeatures);

with m_dockTitleBar being a custom widget for some added padding

In D10325#201884, @broulik wrote:

Would it be possible to show it as if it were locked? That would solve all the issues with it, right?

I don't get it. That "lock" feature is entirely a Dolphin invention. It does exactly what I do here:

void DolphinDockWidget::setLocked(bool lock)
{
    ...
        if (lock) {
            ...
            setTitleBarWidget(m_dockTitleBar);
            setFeatures(QDockWidget::NoDockWidgetFeatures);

with m_dockTitleBar being a custom widget for some added padding

Looks like i was looking at the wrong picture. I was looking at your after image and comparing that to the "locked" state in dolphin.
The image i was expecting is the one you call "crammed at the top" :)

Imho, the "crammed at the top" version looks best as the "after" one just has some weird empty room above the panel now. But feel free to use the one you think fits best.

A suggestion though if you do choose for the "after" version. Would it be possible to rearrange the layout then?
So:

• move the actions to the top, right above the panel.
• move the location bar next to the actions

I think that would look nice :)

If no Frameworks dev objects within next few days this will be pushed