the 32px icons for media-playlist-shuffle and media-playlist-repeat look totally different than the icons with sizes <= 24px.
Also, they do not fit with the current design with their sharp corners. Change to the design of the smaller icons. Icons were created using a scaled version of the 24px icons.
Details
Details
Diff Detail
Diff Detail
- Repository
- R266 Breeze Icons
- Branch
- playlist_shuffle_repeat
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Before:
After, which is also how the 24px and lower icons look like:
Mouse cursors not included of course :)
Disclaimer: I'm in no way a graphic designer.
Comment Actions
only in 16px there is no circle and in general I'm not really happy to have no circle around the icon. maybe for repeat and shuffle it will work but play/pause are more intuitive with circle than without.
Comment Actions
Thanks for the feedback!
So the correct fix would be to change the 22px and 24px icons to use circles around the icons?
This comment was removed by ngraham.
Comment Actions
It is currently pending on @andreask reviewing it, as they have previously requested changes.
It also needs @andreaska to review it (not sure if this is correct?)
Phabricator only considers something ready for landing once all reviewers have approved it.