change 32px icons for playlist shuffle and repeat
ClosedPublic
Actions

Authored by astippich on Feb 4 2018, 12:52 PM.

Details

Reviewers

andreaska
andreask
ngraham

Group Reviewers

Breeze
VDG

Commits

R266:f0a96f5f85cb: change 32px icons for playlist shuffle and repeat

Summary

the 32px icons for media-playlist-shuffle and media-playlist-repeat look totally different than the icons with sizes <= 24px.
Also, they do not fit with the current design with their sharp corners. Change to the design of the smaller icons. Icons were created using a scaled version of the 24px icons.

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

astippich created this revision.Feb 4 2018, 12:52 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 4 2018, 12:52 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

astippich requested review of this revision.Feb 4 2018, 12:52 PM

Before:

After, which is also how the 24px and lower icons look like:

Mouse cursors not included of course :)
Disclaimer: I'm in no way a graphic designer.

astippich edited the summary of this revision. (Show Details)Feb 4 2018, 12:57 PM

update to 1px of line width, was 1.5 due to the scaling

ngraham added a subscriber: ngraham.Feb 4 2018, 4:12 PM

astippich mentioned this in D10279: add 24px media-album-cover icon.Feb 18 2018, 9:41 AM

only in 16px there is no circle and in general I'm not really happy to have no circle around the icon. maybe for repeat and shuffle it will work but play/pause are more intuitive with circle than without.

This revision now requires changes to proceed.Feb 19 2018, 10:27 PM

Thanks for the feedback!
So the correct fix would be to change the 22px and 24px icons to use circles around the icons?

add more 32px icons

after D11049 where the frames for the media buttons were removed I think this is quite needed for a consistent look and feel. I also added 32px version for no repeat and no shuffle which I need for a toggle button for Elisa

ngraham added a comment.Mar 9 2018, 6:42 PM

This comment was removed by ngraham.

Agreed. They look great to me!

ping @andreask

astippich mentioned this in T8249: Move Random and Repeat play actions near the play/pause, skip next and skip previous buttons.Mar 20 2018, 7:39 AM

Can I land this? phabricator doesn't show it as accepted though

It is currently pending on @andreask reviewing it, as they have previously requested changes.

It also needs @andreaska to review it (not sure if this is correct?)

Phabricator only considers something ready for landing once all reviewers have approved it.

sorry for the late approve.

This revision is now accepted and ready to land.Mar 28 2018, 9:00 PM

Thanks a lot!

Closed by commit R266:f0a96f5f85cb: change 32px icons for playlist shuffle and repeat (authored by astippich). · Explain WhyMar 29 2018, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
A	M	icons-dark/actions/32/media-playlist-normal.svg (17 lines)
M		icons-dark/actions/32/media-playlist-repeat.svg (8 lines)
M		icons-dark/actions/32/media-playlist-shuffle.svg (8 lines)
A	M	icons-dark/actions/32/media-repeat-all.svg (1 line)
A	M	icons-dark/actions/32/media-repeat-none.svg (25 lines)
A	M	icons/actions/32/media-playlist-normal.svg (17 lines)
M		icons/actions/32/media-playlist-repeat.svg (8 lines)
M		icons/actions/32/media-playlist-shuffle.svg (8 lines)
A	M	icons/actions/32/media-repeat-all.svg (1 line)
A	M	icons/actions/32/media-repeat-none.svg (25 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26497	18897f3		Feb 4 2018, 12:52 PM	★	★
Diff 2	26512	18897f3	update to 1px of line width, was 1.5 due to the scaling	Feb 4 2018, 3:54 PM	★	★
Diff 3	29110	a8e8589	- add more 32px icons	Mar 9 2018, 6:36 PM	★	★
Diff 4	30868	9479c58	R266:f0a96f5f85cbe276ffe227cac1dba7b33f1c5b5a	Mar 29 2018, 7:18 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
7e6e610666a9	0f235b17863d	f062034cfd53	Alexander Stippich	add more 32px icons	Mar 9 2018, 6:30 PM
f062034cfd53	4989622bf3b4	c27c1549926e	Alexander Stippich	update to 1px of line width	Feb 4 2018, 3:53 PM
c27c1549926e	9700a308a8bf	a8e858933ab9	Alexander Stippich	change 32px icons for playlist shuffle and repeat (Show More…)	Feb 4 2018, 12:19 PM