add 24px media-album-cover icon
ClosedPublic

Authored by astippich on Feb 3 2018, 7:45 PM.

Details

Summary

media-album-cover icon is missing for the 24px size, create symlink to the amarok one like other sizes

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
astippich created this revision.Feb 3 2018, 7:45 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 3 2018, 7:45 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
astippich requested review of this revision.Feb 3 2018, 7:45 PM
ngraham added a subscriber: ngraham.Feb 3 2018, 7:46 PM

Before-and-after screenshots?

It just adds a missing link to an already existing icon, is a screenshot needed?

astippich updated this revision to Diff 26484.Feb 4 2018, 10:08 AM
  • do the same thing for dark icons
astippich updated this revision to Diff 26495.Feb 4 2018, 12:48 PM

use a proper feature branch, which I forgot to use before

Hi, it would be nice to get some feedback on this. Same for D10293 and D10292.
If this is not the proper way to contribute to breeze icons, please point me in the right direction.

You're not doing anything wrong, we're just being a bit slow to respond, and I'm sorry for that. I'll see if I can rustle up some reviewers.

andreask accepted this revision.Feb 19 2018, 10:21 PM
This revision is now accepted and ready to land.Feb 19 2018, 10:21 PM
This revision was automatically updated to reflect the committed changes.