Made a mistake: updated D10113 with a diff supposed to update this.

Both test for empty failed because the spy timed out!
IMO they should not, because consumers rely on the metaDataRequestFinished signal.
Please tell me if you disagree.

I don't know why they fail, yet. See D10113

Patch doesn't apply here, can you update it?

$ arc patch D10119
 INFO  Base commit is not in local repository; trying to fetch.
Branch name arcpatch-D10119 already exists; trying a new name.
Created and checked out branch arcpatch-D10119_1.
Created and checked out branch arcpatch-D10143.
Checking patch src/filemetadataprovider.cpp...
Applied patch src/filemetadataprovider.cpp cleanly.

 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D10143'

STDOUT
(empty)

STDERR
error: could not apply 4c0d4f8... baloo-widgets: Apply coding style to filemetadataprovider
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

(Run with `--trace` for a full exception trace.)

arc patch D10119 still fails with the same error. Don't know why it is D10143 that fails. Hints welcome.

Anyway, I think it's best to do this

• wait for KDE Applications 17.12.2 release.
• then land D10113
• fix the history of this one
• create new diff for filemetadataprovider to make it pass these tests

error: could not apply 88a775b... baloo-widgets: Apply coding style to filemetadataprovider

It seems this is a local commit in your feature branch? Have you tried to rebase this branch on top of master?

This is the best I could accomplish to get arc patch D10119 working, sorry.

• I had to resolve 35 conflicts during rebase to master.
• After that the diff looked like this one. (Duplication of changes in D10113)
• Then:

$ git status
Auf Branch unittest
Ihr Branch und 'signalavailable' sind divergiert,
und haben jeweils 26 und 19 unterschiedliche Commits.
  (benutzen Sie "git pull", um Ihren Branch mit dem Remote-Branch zusammenzuführen)

nichts zu committen, Arbeitsverzeichnis unverändert

• $ git pull ( Resolved conflicts)
• arc diff
• ... same error during arc patch D10119
• $ git checkout -b rebaseunittest b58d7b66bbf213eb15672d7ffa5346fa31c7243d (commit before doing $ git pull)
• Manually adjusted two blank lines
• arc diff => this diff

Connection to D10113 is lost, but least this one compiles after 'arc patch D10119` and the tests have the expect result (FAIL with empty list).

@michaelh Why is D10113 not pushed yet? You need to rebase this patch on top of master *after* you push D10113.

@elvisangelaccio: D10113 currently fails shouldSignalOnceWithoutFile() and shouldSignalOnceWithEmptyFile() for reasons I don't understand. The correct code path is taken, but no signal is emitted in src/filemetadatawidget.cpp:119
I hadn't pushed D10113 because I was waiting for your comment on this.

Treated all test equally: QVERIFY(spy.wait(xxx)); -> spy.wait(xxx)
shouldSignalOnceWithoutFile() and shouldSignalOnceWithEmptyFile() still fail, the others pass.

Just to see what would happen I changed filemetadataprovider.cpp:465 to

KFileItemList FileMetaDataProvider::items() const
{
    return m_fileItems.isEmpty() 
        ? KFileItemList() << QUrl(QStringLiteral("file:///"))
        : m_fileItems;
}

Now all tests pass.

The crux must be in build/kde/applications/baloo-widgets/src/KF5BalooWidgets_autogen/include/moc_filemetadatawidget.cpp:

// SIGNAL 1
void Baloo::FileMetaDataWidget::metaDataRequestFinished(const KFileItemList & _t1)
{
    void *_a[] = { nullptr, const_cast<void*>(reinterpret_cast<const void*>(&_t1)) };
    QMetaObject::activate(this, &staticMetaObject, 1, _a);
}

I can't read this, but hopefully you can tell why there is no signal when _t1 is an empty list.

Almost there, just coding style issues now :)

Thank you for your patience.

My inline comments do not appear where they should.

• Deleting cleanupTestCase() gave a linker error.
• Deleting qRegisterMetaType 4 Debug warnings

In D10119#203751, @michaelh wrote:

My inline comments do not appear where they should.

• Deleting cleanupTestCase() gave a linker error.

Did you also remove the declaration in filemetadatawidgettest.h?

• Deleting qRegisterMetaType 4 Debug warnings

Weird, works here without it. Oh well, let's put it then (better safe than sorry).

Did you also remove the declaration in filemetadatawidgettest.h?

Good question :)