baloo-widgets: Apply coding style to filemetadataprovider
ClosedPublic
Actions

Authored by michaelh on Jan 27 2018, 1:18 PM.

Details

Reviewers

Group Reviewers

Dolphin

Commits

Summary

Prepare fixing bug 388583

CCBUG: 388583

Test Plan

Visual inspection
make test

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

michaelh requested review of this revision.Jan 27 2018, 1:18 PM

michaelh created this revision.

Thanks

This revision is now accepted and ready to land.Jan 27 2018, 1:58 PM

This revision was automatically updated to reflect the committed changes.

Did this actually get committed? I can't see it in the baloo-widgets git history, and the URL linked to from the bug you CCd isn't valid: https://cgit.kde.org/baloo-widgets.git/commit/?id=e9049626222c1b0d90c8e714c71440c9a7bc0e58

Never mind, looks like it's there in the git history, but the web interface isn't updating properly. I'll get this sorted out.

			Path	Packages
M			src/filemetadataprovider.cpp (97 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	26052	1dd9509		Jan 27 2018, 12:40 PM	★	★
Diff 2	26063	1963185	R824:e9049626222c1b0d90c8e714c71440c9a7bc0e58	Jan 27 2018, 2:45 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
9fc02e67819a	a1b858fee94c	1dd9509a29f1	Michael Heidelbach	Applied coding style	Jan 27 2018, 12:40 PM

Status	Author	Revision
Closed	michaelh	D10149 baloo-widgets: Add autotest for asychronously extracted data
Closed	michaelh	D10119 baloo-widgets: Create test to assert metaDataRequestFinished is emitted once only
Closed	michaelh	D10113 baloo-widgets: Emit metaDataRequestFinished once per request
Closed	michaelh	D10105 baloo-widgets: Refactor filemetadataprovider for better readability
Closed	michaelh	D10143 baloo-widgets: Apply coding style to filemetadataprovider
Closed	michaelh	D10834 filemetadatawidget: Use object names
Closed	michaelh	D10833 Remove dataavailable signal