Differential D10834

filemetadatawidget: Use object names
ClosedPublic
Actions

Authored by michaelh on Feb 25 2018, 1:06 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Dolphin
Baloo
Commits
R824:03d9abe7eb25: filemetadatawidget: Use object names
Summary

Using object names for contained widget facilitates unit testing

Diff Detail

Repository
R824 Baloo Widgets
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh requested review of this revision.Feb 25 2018, 1:06 PM
michaelh created this revision.
michaelh added a dependency: D10833: Remove dataavailable signal.
elvisangelaccio added inline comments.Feb 25 2018, 1:57 PM
src/filemetadatawidget.cpp
71

As I mentioned in the other review, QString objects are usually passed by const reference. I don't really see a reason to do it differently here.

117–118

Could by simplified with new QLabel(itemLabel + QLatin1Char(':'), parent), see comment above.

michaelh updated this revision to Diff 28029.Feb 25 2018, 2:04 PM
  • filemetadatawidget: Use const
This revision is now accepted and ready to land.Feb 25 2018, 2:11 PM
Closed by commit R824:03d9abe7eb25: filemetadatawidget: Use object names (authored by michaelh). · Explain WhyFeb 25 2018, 2:14 PM
This revision was automatically updated to reflect the committed changes.
michaelh marked 2 inline comments as done.

Revision Contents
Changeset List

PathPackages
Msrc/filemetadatawidget.cpp (72 lines)
Msrc/metadatafilter.h (3 lines)
Msrc/widgetfactory.cpp (2 lines)

Diff 28031

View Options

src/filemetadatawidget.cpp

Loading...
View Options

src/metadatafilter.h

Loading...
View Options

src/widgetfactory.cpp

Loading...