Differential D10079

[Draft] Port baloo krunner plugin to KDBusRunner
AbandonedPublic
Actions

Authored by kossebau on Jan 24 2018, 3:27 PM.

Details

Reviewers
davidedmundson
broulik
mart
Summary

Sample port of proposed new KF5 lib KDBusRunner (D10078 for discussion of that).

To be done/pushed once KDBusRunner has been finalized and published.

Diff Detail

Repository
R120 Plasma Workspace
Branch
portBalooRunnerToKDBusRunner
Lint
No Linters Available
Unit
No Unit Test Coverage
kossebau created this revision.Jan 24 2018, 3:27 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2018, 3:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
kossebau requested review of this revision.Jan 24 2018, 3:27 PM
mart accepted this revision.Jan 26 2018, 1:04 PM
This revision is now accepted and ready to land.Jan 26 2018, 1:04 PM
kossebau retitled this revision from Port baloo krunner plugin to KDBusRunner to [Draft] Port baloo krunner plugin to KDBusRunner.Jan 26 2018, 4:36 PM
kossebau edited the summary of this revision. (Show Details)
michaelh added inline comments.Feb 17 2018, 6:20 PM
runners/baloo/baloosearchrunner.cpp
107

Baloo can also handle these types

  • Archive
  • Spreadsheet (also found with type:Document)
  • Presentation (also found with type:Document)

see basicindexingjob
Currently those can only be found with e.g. $ baloosearch type:Archive.
Please make them available in KRunner too.

kossebau added inline comments.Feb 17 2018, 7:13 PM
runners/baloo/baloosearchrunner.cpp
107

I agree those would be useful to cover, too.

Adding suppotr for that though is orthogonal to this patch/work. @michaelh please file a bug for this as reminder (or perhaps do a straight patch against current master :) ).

kossebau updated this revision to Diff 33027.Apr 25 2018, 12:47 AM
kossebau retitled this revision from [Draft] Port baloo krunner plugin to KDBusRunner to [Draft] Port baloo krunner plugin to KDBusRunner.

update to latest kdbusrunner

davidedmundson requested changes to this revision.Apr 26 2018, 3:47 PM
davidedmundson added inline comments.
runners/baloo/baloosearchrunner.cpp
78–79

You don't need any of this

This revision now requires changes to proceed.Apr 26 2018, 3:47 PM
kossebau updated this revision to Diff 33251.Apr 28 2018, 1:59 PM

remove explicit cancelling of superseded MatchReply

davidedmundson accepted this revision.May 1 2018, 10:32 AM
This revision is now accepted and ready to land.May 1 2018, 10:32 AM
kossebau abandoned this revision.May 1 2018, 4:03 PM

Discarded for now following discarding of used lib KF5DBusRunner

Revision Contents
Changeset List

Diff 33251

View Options

CMakeLists.txt

Loading...
View Options

runners/baloo/CMakeLists.txt

Loading...
View Options

runners/baloo/baloosearchrunner.h

Loading...
View Options

runners/baloo/baloosearchrunner.cpp

Loading...
View Options

runners/baloo/dbusutils_p.h

Loading...
View Options

runners/baloo/org.kde.krunner1.xml

Loading...