I come a bit late in the discussion, sorry about that :/
@manueljlin I kindly disagree with the proposed UI for words because it reproduces the same mistake as every other word processor (MS Word, LibreOffice Writer, probably Corel WordPerfect).
There is a very deep flaw in the WISIWYG world. When you set a piece of text in bold, this is 99% of the time not what you want to do. What you wanted to do is an emphasis of this text. The difference is subtle but major in user interface. I think there is a place in the word processor landscape for a style first word processor. No bold button, but emphasis style. Numbered list being harder to reach than a title style…
I'm not good at UX and UI design, but do you think there is a way to do that? Getting out of the Word box most UIs are in?

Fixes done

• It's flying fine
• Fixes from mlaurent review

All your comments have been taken into account, branch cleaned, rebased on top of origin/master. And it has been dog-fed for more than a year… (so sorry for the delay)

• Further delay loading articles on fetch
• Introduce new Storage::articlesForCache

Laurent prefers it that way :)

Hum, sure it is an optimization on a non-optimizing compiler, but since QModelIndex::row() is const and declared in the headers, thus inlined when called, we don't really get anything here (on the contrary, on a -O3 code with GCC 9.2 on amd64 we get two extra instructions and allocate more stack because the variable is kept).
Are you sure it is worth it?

Fix indent.

While writing the explanation for Laurent, I felt stupid for not writing
this patch that way the first time.

In D24963#554392, @mlaurent wrote:

You select one article and it opens 2 articles ?
Perhaps we need to understand why before to create a workaround no ?

Merged in master.

I fixed for mlaurent.
I also fixed a new warning about the .css files that do not exist. Previously, they generated silent errors, but now that the baseUrl does not allow by default file:// urls, it appears in the program output.

• Drop reference to .css files that do not exist
• Output the xmlUri to help debug, as asked by mlaurent

• Fix segfault when adding feed

• Remove wrong comment

Nice catch. I'm wondering what was the use of this code 10 years ago.

• Fixes following review

• Use the new FeedStorage::article() call

Rebase on latest master.

With all these changes, akregator starts up almost instantly on my computer. RAM usage is far lower at startup (but sadly still grows once feeds are fetched, there are still ways for improvement here).
Also I suspect the guid 'cache' was a quite nice long term leak in akregator. I have no idea since how long that leak existed…

• Make sure all articles are not fetched uselessly at start/end

Add missing fix

I merged this in https://cgit.kde.org/akregator.git/commit/?id=37f6e3a6f2ddbaba289f1ef7baf54ce71281798a, I did a small mistake in the git message and it didn't close this review, sorry about that.

@knauss yes I can, I am currently merging these 3 reviews.