Don't push private APIs in the public 'interface'
ClosedPublic
Actions

Authored by pinaraf on Apr 22 2018, 4:03 PM.

Details

Reviewers

mlaurent
knauss

Commits

R201:74e40e5e8bf7: Don't push private APIs in the public 'interface'

Summary

The current interface mixes really public stuff
and stuff required only for MK4 or the Dummy storages.
This makes it far harder to understand 'who' does 'what'.

This commit drops a part of that legacy.

Diff Detail

Repository

R201 Akregator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

pinaraf created this revision.Apr 22 2018, 4:03 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2018, 4:03 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

Add missing fix

pinaraf added reviewers: mlaurent, knauss.Apr 23 2018, 4:47 PM

Rebase on latest master.

mlaurent accepted this revision.Apr 24 2018, 6:07 AM

This revision is now accepted and ready to land.Apr 24 2018, 6:07 AM

Closed by commit R201:74e40e5e8bf7: Don't push private APIs in the public 'interface' (authored by pinaraf). · Explain WhyApr 24 2018, 11:22 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			interfaces/storage.h (6 lines)
M			plugins/mk4storage/storagemk4impl.h (14 lines)
M			src/dummystorage/feedstoragedummyimpl.cpp (2 lines)
M			src/dummystorage/storagedummyimpl.h (14 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	32822	8ff9741		Apr 22 2018, 4:03 PM	★	★
Diff 2	32823	8ff9741	Add missing fix	Apr 22 2018, 4:04 PM	★	★
Diff 3	32928	18daf05	Rebase on latest master.	Apr 23 2018, 10:28 PM	★	★
Diff 4	32967	9ba1d3f	R201:74e40e5e8bf71ed3fd0ca3bd24f3cd107a476eef	Apr 24 2018, 11:22 AM	★	★