pinaraf (Pierre Ducroquet)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Apr 19 2018, 12:50 PM (92 w, 17 h)
Availability
Available

Recent Activity

Oct 31 2019

pinaraf added a comment to D13135: Introduce Storage::articlesForCache and more lazy-loading.

Fixes done

Oct 31 2019, 7:42 PM · KDE PIM
pinaraf updated the diff for D13135: Introduce Storage::articlesForCache and more lazy-loading.
  • It's flying fine
  • Fixes from mlaurent review
Oct 31 2019, 7:40 PM · KDE PIM

Oct 29 2019

pinaraf added a comment to D13135: Introduce Storage::articlesForCache and more lazy-loading.

All your comments have been taken into account, branch cleaned, rebased on top of origin/master. And it has been dog-fed for more than a year… (so sorry for the delay)

Oct 29 2019, 10:22 PM · KDE PIM
pinaraf updated the diff for D13135: Introduce Storage::articlesForCache and more lazy-loading.
  • Further delay loading articles on fetch
  • Introduce new Storage::articlesForCache
Oct 29 2019, 10:20 PM · KDE PIM
pinaraf committed R201:3ec080aa315e: Fix invalid feeds in default settings (authored by pinaraf).
Fix invalid feeds in default settings
Oct 29 2019, 12:34 PM
pinaraf committed R201:9c300d36ec8c: Prevent duplicates in url list. (authored by pinaraf).
Prevent duplicates in url list.
Oct 29 2019, 8:24 AM
pinaraf closed D24963: Prevent duplicates in url list..
Oct 29 2019, 8:24 AM · KDE PIM
pinaraf updated the diff for D24963: Prevent duplicates in url list..

Laurent prefers it that way :)

Oct 29 2019, 8:01 AM · KDE PIM

Oct 28 2019

pinaraf added a comment to D24963: Prevent duplicates in url list..

Hum, sure it is an optimization on a non-optimizing compiler, but since QModelIndex::row() is const and declared in the headers, thus inlined when called, we don't really get anything here (on the contrary, on a -O3 code with GCC 9.2 on amd64 we get two extra instructions and allocate more stack because the variable is kept).
Are you sure it is worth it?

Oct 28 2019, 8:49 AM · KDE PIM

Oct 26 2019

pinaraf updated the diff for D24963: Prevent duplicates in url list..

Fix indent.

Oct 26 2019, 8:35 PM · KDE PIM
pinaraf updated the diff for D24963: Prevent duplicates in url list..

While writing the explanation for Laurent, I felt stupid for not writing
this patch that way the first time.

Oct 26 2019, 8:34 PM · KDE PIM
pinaraf added a comment to D24963: Prevent duplicates in url list..

You select one article and it opens 2 articles ?
Perhaps we need to understand why before to create a workaround no ?

Oct 26 2019, 8:32 PM · KDE PIM
pinaraf added reviewers for D24963: Prevent duplicates in url list.: mlaurent, KDE PIM.
Oct 26 2019, 12:51 PM · KDE PIM
pinaraf requested review of D24963: Prevent duplicates in url list..
Oct 26 2019, 12:41 PM · KDE PIM

Mar 20 2019

pinaraf committed R201:7c05d699d92e: Output the xmlUri to help debug, as asked by mlaurent (authored by pinaraf).
Output the xmlUri to help debug, as asked by mlaurent
Mar 20 2019, 11:01 AM
pinaraf committed R201:7a662f113ff5: Drop reference to .css files that do not exist (authored by pinaraf).
Drop reference to .css files that do not exist
Mar 20 2019, 11:01 AM
pinaraf committed R201:fbd04c0045a5: Make the feed uri the baseUrl for previews (authored by pinaraf).
Make the feed uri the baseUrl for previews
Mar 20 2019, 11:01 AM
pinaraf closed D19739: Make the feed uri the baseUrl for previews.

Merged in master.

Mar 20 2019, 10:33 AM · KDE PIM

Mar 19 2019

pinaraf added a comment to D19739: Make the feed uri the baseUrl for previews.

I fixed for mlaurent.
I also fixed a new warning about the .css files that do not exist. Previously, they generated silent errors, but now that the baseUrl does not allow by default file:// urls, it appears in the program output.

Mar 19 2019, 8:19 PM · KDE PIM
pinaraf updated the diff for D19739: Make the feed uri the baseUrl for previews.
  • Drop reference to .css files that do not exist
  • Output the xmlUri to help debug, as asked by mlaurent
Mar 19 2019, 8:14 PM · KDE PIM

Mar 14 2019

pinaraf requested review of D19739: Make the feed uri the baseUrl for previews.
Mar 14 2019, 8:54 PM · KDE PIM
pinaraf added inline comments to D19739: Make the feed uri the baseUrl for previews.
Mar 14 2019, 8:33 PM · KDE PIM

Mar 13 2019

pinaraf added a reviewer for D19739: Make the feed uri the baseUrl for previews: KDE PIM.
Mar 13 2019, 9:44 PM · KDE PIM
pinaraf requested review of D19739: Make the feed uri the baseUrl for previews.
Mar 13 2019, 9:43 PM · KDE PIM

Jun 10 2018

pinaraf updated the diff for D13135: Introduce Storage::articlesForCache and more lazy-loading.
  • Fix segfault when adding feed
Jun 10 2018, 8:49 PM · KDE PIM

May 26 2018

pinaraf updated the diff for D13135: Introduce Storage::articlesForCache and more lazy-loading.
  • Remove wrong comment
May 26 2018, 11:15 AM · KDE PIM
pinaraf added a reviewer for D13135: Introduce Storage::articlesForCache and more lazy-loading: cgiboudeaux.
May 26 2018, 11:10 AM · KDE PIM
pinaraf requested review of D13135: Introduce Storage::articlesForCache and more lazy-loading.
May 26 2018, 11:05 AM · KDE PIM
pinaraf committed R201:b328eaeabe30: Order QWebEngine settings, remove duplicate (authored by pinaraf).
Order QWebEngine settings, remove duplicate
May 26 2018, 11:03 AM

May 2 2018

pinaraf committed R201:412536c4a4eb: FeedStorage::commit and rollback are MK4 specific (authored by pinaraf).
FeedStorage::commit and rollback are MK4 specific
May 2 2018, 5:55 PM
pinaraf committed R201:531bc912440a: Get rid of close / clear (authored by pinaraf).
Get rid of close / clear
May 2 2018, 5:03 PM
pinaraf committed R201:ae31c1a1cf2a: Several performance optimisations for Akregator (authored by pinaraf).
Several performance optimisations for Akregator
May 2 2018, 4:52 PM
pinaraf closed D12480: Several performance optimisations for Akregator.
May 2 2018, 4:52 PM · KDE PIM

Apr 30 2018

pinaraf accepted D12473: Fix going to prev/next article with keyboard when using load full website.

Nice catch. I'm wondering what was the use of this code 10 years ago.

Apr 30 2018, 4:25 PM · KDE PIM

Apr 24 2018

pinaraf added inline comments to D12480: Several performance optimisations for Akregator.
Apr 24 2018, 8:33 PM · KDE PIM
pinaraf updated the diff for D12480: Several performance optimisations for Akregator.
  • Fixes following review
Apr 24 2018, 8:33 PM · KDE PIM
pinaraf committed R201:74e40e5e8bf7: Don't push private APIs in the public 'interface' (authored by pinaraf).
Don't push private APIs in the public 'interface'
Apr 24 2018, 11:22 AM
pinaraf closed D12451: Don't push private APIs in the public 'interface'.
Apr 24 2018, 11:22 AM · KDE PIM
pinaraf added inline comments to D12480: Several performance optimisations for Akregator.
Apr 24 2018, 10:27 AM · KDE PIM
pinaraf added reviewers for D12480: Several performance optimisations for Akregator: mlaurent, knauss.
Apr 24 2018, 10:14 AM · KDE PIM
pinaraf updated the diff for D12480: Several performance optimisations for Akregator.
  • Use the new FeedStorage::article() call
Apr 24 2018, 6:59 AM · KDE PIM

Apr 23 2018

pinaraf updated the diff for D12451: Don't push private APIs in the public 'interface'.

Rebase on latest master.

Apr 23 2018, 10:28 PM · KDE PIM
pinaraf added a comment to D12480: Several performance optimisations for Akregator.

With all these changes, akregator starts up almost instantly on my computer. RAM usage is far lower at startup (but sadly still grows once feeds are fetched, there are still ways for improvement here).
Also I suspect the guid 'cache' was a quite nice long term leak in akregator. I have no idea since how long that leak existed…

Apr 23 2018, 10:22 PM · KDE PIM
pinaraf updated the diff for D12480: Several performance optimisations for Akregator.
  • Make sure all articles are not fetched uselessly at start/end
Apr 23 2018, 10:20 PM · KDE PIM
pinaraf requested review of D12480: Several performance optimisations for Akregator.
Apr 23 2018, 9:40 PM · KDE PIM
pinaraf added reviewers for D12451: Don't push private APIs in the public 'interface': mlaurent, knauss.
Apr 23 2018, 4:47 PM · KDE PIM

Apr 22 2018

pinaraf committed R201:0e73e502671e: Drop unused functions from storage (authored by pinaraf).
Drop unused functions from storage
Apr 22 2018, 4:49 PM
pinaraf closed D12450: Drop unused functions from storage.
Apr 22 2018, 4:49 PM · KDE PIM
pinaraf updated the diff for D12451: Don't push private APIs in the public 'interface'.

Add missing fix

Apr 22 2018, 4:04 PM · KDE PIM
pinaraf requested review of D12451: Don't push private APIs in the public 'interface'.
Apr 22 2018, 4:03 PM · KDE PIM
pinaraf requested review of D12450: Drop unused functions from storage.
Apr 22 2018, 3:58 PM · KDE PIM
pinaraf committed R201:8ff9741caee5: Fix build - forgot to add these 4 lines to review (authored by pinaraf).
Fix build - forgot to add these 4 lines to review
Apr 22 2018, 2:09 PM
pinaraf committed R201:8d3bc6cab373: Drop comment support, disabled since 10+ years (authored by pinaraf).
Drop comment support, disabled since 10+ years
Apr 22 2018, 2:05 PM
pinaraf closed D12442: Drop comment support, disabled since 10+ years.
Apr 22 2018, 2:05 PM · KDE PIM
pinaraf committed R201:abefc1b4e1a0: TagSet in storage was unused, drop it (authored by pinaraf).
TagSet in storage was unused, drop it
Apr 22 2018, 2:05 PM
pinaraf closed D12441: TagSet in storage was unused, drop it.
Apr 22 2018, 2:04 PM · KDE PIM
pinaraf committed R201:7dd054ba7c39: Convert lastFetch to QDateTime (authored by pinaraf).
Convert lastFetch to QDateTime
Apr 22 2018, 2:03 PM
pinaraf closed D12440: Convert lastFetch to QDateTime.
Apr 22 2018, 2:03 PM · KDE PIM
pinaraf requested review of D12442: Drop comment support, disabled since 10+ years.
Apr 22 2018, 12:11 PM · KDE PIM
pinaraf requested review of D12441: TagSet in storage was unused, drop it.
Apr 22 2018, 12:11 PM · KDE PIM
pinaraf requested review of D12440: Convert lastFetch to QDateTime.
Apr 22 2018, 12:11 PM · KDE PIM
pinaraf abandoned D12347: Drop tag and categories from storage.
Apr 22 2018, 11:38 AM · KDE PIM
pinaraf added an edge to R201:37f6e3a6f2dd: Drop tag and categories from storage: D12347: Drop tag and categories from storage.
Apr 22 2018, 11:28 AM
pinaraf added 1 commit(s) for D12347: Drop tag and categories from storage: R201:37f6e3a6f2dd: Drop tag and categories from storage.
Apr 22 2018, 11:28 AM · KDE PIM
pinaraf committed R201:93a60654996e: Keep the pubDate as a QDateTime in storage (authored by pinaraf).
Keep the pubDate as a QDateTime in storage
Apr 22 2018, 11:23 AM
pinaraf closed D12349: Keep the pubDate as a QDateTime in storage.
Apr 22 2018, 11:22 AM · KDE PIM
pinaraf committed R201:3b975a1b3331: Get rid of convertOldArchive logic (authored by pinaraf).
Get rid of convertOldArchive logic
Apr 22 2018, 11:21 AM
pinaraf closed D12348: Drop convertOldArchive.
Apr 22 2018, 11:21 AM · KDE PIM
pinaraf added a comment to D12347: Drop tag and categories from storage.

I merged this in https://cgit.kde.org/akregator.git/commit/?id=37f6e3a6f2ddbaba289f1ef7baf54ce71281798a, I did a small mistake in the git message and it didn't close this review, sorry about that.

Apr 22 2018, 11:19 AM · KDE PIM
pinaraf added a comment to D12349: Keep the pubDate as a QDateTime in storage.

@knauss yes I can, I am currently merging these 3 reviews.

Apr 22 2018, 11:17 AM · KDE PIM
pinaraf committed R201:37f6e3a6f2dd: Drop tag and categories from storage (authored by pinaraf).
Drop tag and categories from storage
Apr 22 2018, 11:15 AM

Apr 19 2018

pinaraf requested review of D12349: Keep the pubDate as a QDateTime in storage.
Apr 19 2018, 1:02 PM · KDE PIM
pinaraf requested review of D12348: Drop convertOldArchive.
Apr 19 2018, 1:00 PM · KDE PIM
pinaraf requested review of D12347: Drop tag and categories from storage.
Apr 19 2018, 12:56 PM · KDE PIM