Drop unused functions from storage
ClosedPublic
Actions

Authored by pinaraf on Apr 22 2018, 3:58 PM.

Details

Reviewers

Commits

R201:0e73e502671e: Drop unused functions from storage

Summary

These functions are not used, and I see no sign of their
previous callers.
In my opinion, they do not make much sense : these operations
belong to a higher level that would pass the data around using
the same API as when fetching/viewing articles.

Diff Detail

Repository

R201 Akregator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

pinaraf created this revision.Apr 22 2018, 3:58 PM

Restricted Application added a project: KDE PIM. · View Herald TranscriptApr 22 2018, 3:58 PM

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

pinaraf requested review of this revision.Apr 22 2018, 3:58 PM

knauss accepted this revision.Apr 22 2018, 4:32 PM

This revision is now accepted and ready to land.Apr 22 2018, 4:32 PM

Closed by commit R201:0e73e502671e: Drop unused functions from storage (authored by pinaraf). · Explain WhyApr 22 2018, 4:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			interfaces/feedstorage.h (8 lines)
M			interfaces/storage.h (7 lines)
M			plugins/mk4storage/feedstoragemk4impl.h (2 lines)
M			plugins/mk4storage/feedstoragemk4impl.cpp (29 lines)
M			plugins/mk4storage/storagemk4impl.h (7 lines)
M			plugins/mk4storage/storagemk4impl.cpp (15 lines)
M			src/dummystorage/feedstoragedummyimpl.h (3 lines)
M			src/dummystorage/feedstoragedummyimpl.cpp (28 lines)
M			src/dummystorage/storagedummyimpl.h (7 lines)
M			src/dummystorage/storagedummyimpl.cpp (13 lines)