fazek (László Fazekas)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 24 2016, 7:44 AM (484 w, 6 d)
Availability
Available

Recent Activity

Jun 19 2017

fazek committed R37:b083174dc8e5: fix CSV file saver animated channel bug (authored by fazek).
fix CSV file saver animated channel bug
Jun 19 2017, 4:48 PM

Apr 27 2017

fazek committed R37:82bcbd7b91dc: fix CSV file saver crash (authored by fazek).
fix CSV file saver crash
Apr 27 2017, 12:25 PM

Mar 13 2017

fazek committed R37:8679229b6663: bug 375878 - Eraser will not switch back to brush after turning Wacom pen back… (authored by fazek).
bug 375878 - Eraser will not switch back to brush after turning Wacom pen back…
Mar 13 2017, 11:13 AM

Sep 29 2016

fazek abandoned D2822: Krita: mouse wheel on the timeline.
Sep 29 2016, 8:07 AM
fazek committed R37:cc63ae3adb23: patch D2822: mouse wheel support for the animation timeline (authored by fazek).
patch D2822: mouse wheel support for the animation timeline
Sep 29 2016, 8:07 AM
fazek added a comment to D2822: Krita: mouse wheel on the timeline.

After one week of no answer, I tried to implement the shift+wheel vertical positioning. It's not useful because of the nature of the timeline and how it's showing and hiding the layers. I think it's better not to add it. The original version seems working fine, so I'm not waiting for the revision and committed it to master.

Sep 29 2016, 8:06 AM

Sep 21 2016

fazek added a comment to D2822: Krita: mouse wheel on the timeline.

I just have an idea for some improvement, but not checked if it's possible:
this is horizontal movement now, maybe shift+wheel could be the vertical, if more than one layer is visible. Ctrl+wheel is nicely working to select a range of frames (at least on Linux).

Sep 21 2016, 8:17 AM

Sep 20 2016

fazek retitled D2822: Krita: mouse wheel on the timeline from to Krita: mouse wheel on the timeline.
Sep 20 2016, 7:12 PM

Aug 25 2016

fazek committed R37:eda471fe0ebd: bug 367774: csv format doesn't export (authored by fazek).
bug 367774: csv format doesn't export
Aug 25 2016, 3:05 PM

Aug 18 2016

fazek committed R37:05020343e3b5: Support for TVPaint's new CSV 1.1 format (authored by fazek).
Support for TVPaint's new CSV 1.1 format
Aug 18 2016, 11:20 AM

Jul 21 2016

fazek closed D2237: Switch off "canvas only" mode before closing the main window.

Thank you @dkazakov, pushed commit 4f3d21273b4b7e984af447696076ab23dc4669e2.

Jul 21 2016, 8:10 PM
fazek committed R37:4f3d21273b4b: Switch off "canvas only" mode before closing the main window (authored by fazek).
Switch off "canvas only" mode before closing the main window
Jul 21 2016, 8:06 PM

Jul 20 2016

fazek retitled D2237: Switch off "canvas only" mode before closing the main window from to Switch off "canvas only" mode before closing the main window.
Jul 20 2016, 2:50 PM

May 5 2016

fazek added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

also found some QLabels without translations, please check:

May 5 2016, 5:13 PM · Krita: Stable
fazek added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

After a quick search, there are still some setToolTip() calls without i18n():

May 5 2016, 4:55 PM · Krita: Stable

May 2 2016

fazek closed D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

Pushed to master.

May 2 2016, 7:50 PM
fazek committed R37:2e85378bd314: clear existing keyframe with the Blank Frame button of the Animation Docker (authored by fazek).
clear existing keyframe with the Blank Frame button of the Animation Docker
May 2 2016, 7:47 PM
fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

This is the final version then.

May 2 2016, 6:15 PM

Apr 30 2016

fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

In this version I added a universal clear function to KisToolUtils. This is a better place than KisLayerUtils because the other contents of KisLayerUtils are maintaining a lower level of functionality, below the UI. This new function can clear the canvas with or without its selection. I also modified the deleteSelection() function in KisTool to use this new function.

Apr 30 2016, 6:43 AM
fazek added a comment to D1166: BUG:360677 KisUpdaterContext should not kill threads in waitForDone().

As far as I can understand, the original solution closes and reopens the threads. This works, just takes too much time and resources. So a solution to wait for a monent when there is no thread running, is good. It's only a hazard for the future, currently nothing creates new jobs infinitely during the wait.

Apr 30 2016, 3:28 AM

Apr 28 2016

fazek added a comment to D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

@dkazakov : How to make it? As I see I cannot put KisPart, KisView... etc. includes nicely into kis_layer_utils. The files in libs/image cannot include things from libs/ui. What if I create the new function in KisTool instead?

Apr 28 2016, 8:41 AM

Apr 27 2016

fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

I've added the new tool function deleteAll(). It clears the contents regardless of the selection. Perhaps it will be useful somewhere else too. Currently implemented as an empty function for most of the tools.

Apr 27 2016, 5:55 PM
fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

Ok, so I removed the KisPart modifications. It's not worth the effort, there are just too few occurrences in the code. This solution is working, the only bad thing is the masking with the selection.

Apr 27 2016, 5:18 PM
fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

Just a minor change: I call the deleteSelection() function directly now.

Apr 27 2016, 4:28 PM
fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

Unfortunately KisImage is below KisView in the hierarchy. So it's easier to add this function to KisPart instead. I've checked the code and it would be useful a similar function for KisDocument too.

Apr 27 2016, 4:10 PM
fazek added a comment to D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

Ugh, I don't really understand the concept of this node manipulation interface yet... But what about to add a member function for the image itself?

Apr 27 2016, 2:28 PM

Apr 26 2016

fazek added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

@rempt: from the first menu, only the "&File" and "&Save" keys has no msgctxt in the .po file. And on your picture these are the only translated ones.
Good night!

Apr 26 2016, 8:43 PM · Krita: Stable
fazek added a comment to T2333: Some of ui are left untranslated on windows though they are translated in translation resource files (3.0 alpha git f38b47e).

About the ampersand: I think the translation is using a hash table for the i18n translation. Maybe the hash code calculation drops the ampersand (perhaps together with other "whitespace" characters) for some reason. In this case the two strings has the same hash id.

Apr 26 2016, 7:57 PM · Krita: Stable

Apr 25 2016

fazek updated the diff for D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

This is the next version. Is there a better way to get the viewManager address here?
If there is a selection, this solution clears only the parts inside it.

Apr 25 2016, 9:11 PM
fazek added a comment to D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.

I understand your opinion and I agree, but there are two things here:

Apr 25 2016, 5:25 PM
fazek retitled D1480: Krita: clear existing keyframe with the Blank Frame button of the Animation Docker from to Krita: clear existing keyframe with the Blank Frame button of the Animation Docker.
Apr 25 2016, 6:06 AM

Apr 23 2016

fazek added a comment to D1166: BUG:360677 KisUpdaterContext should not kill threads in waitForDone().

The cpunters for the threads is a good idea. For me this solution is good if the number of the threads and their order cannot change during the wait cycle.

Apr 23 2016, 4:40 AM

Apr 6 2016

fazek added a comment to T1185: OCIO crashes consistently on some devices in Krita 3.0.

I think it's good now, no crash anymore.

Apr 6 2016, 4:17 PM · Krita: 3.0 bugs sprint, Krita
fazek added a comment to T1185: OCIO crashes consistently on some devices in Krita 3.0.

My problem is still happens, perhaps not related but who knows? This is what I found:

Apr 6 2016, 9:51 AM · Krita: 3.0 bugs sprint, Krita

Apr 3 2016

fazek added a comment to T1185: OCIO crashes consistently on some devices in Krita 3.0.

I have a canvas and OpenGL on. Then I switch off OpenGL and exit the program. The program crashes with segfault in KisOpenGLImageTextures::destroyImageTextureTiles(). The crash happens when it calls delete tile, the deleted tile is the first on the list and it's value is not NULL.

Apr 3 2016, 4:08 PM · Krita: 3.0 bugs sprint, Krita

Apr 2 2016

fazek added a comment to T1853: Write animation pages.

Updated the .csv page. I also included a picture from the TVPaint GUI for the export settings, I hope it won't hurt them, but please check it.

Apr 2 2016, 9:26 AM · Krita: Stable

Mar 29 2016

fazek added a comment to T1853: Write animation pages.

@voltherav: I've created the page, please check and feel free to correct it. I'm thinking about some picture illustrations now. What do you think, could I add screenshots from TVPaint as well?

Mar 29 2016, 8:09 AM · Krita: Stable

Mar 26 2016

fazek added a comment to T1853: Write animation pages.

Ok, I'm going to make something for the csv format. But I need somebody to check the grammar, my English is a bit weak.

Mar 26 2016, 5:20 PM · Krita: Stable
fazek closed T1916: Wrong colors in OpenGL accelerated animation playback as Resolved.
Mar 26 2016, 1:02 PM · Krita: 3.0 bugs sprint
fazek committed R37:21a74f8e5dd1: T1916 Wrong colors in OpenGL accelerated animation playback (authored by fazek).
T1916 Wrong colors in OpenGL accelerated animation playback
Mar 26 2016, 12:59 PM

Mar 25 2016

fazek closed D1215: Wacom tablet crash in Krita.
Mar 25 2016, 12:50 PM
fazek committed R37:5da2ff72bf1d: D1215 Wacom tablet crash in Krita (authored by fazek).
D1215 Wacom tablet crash in Krita
Mar 25 2016, 12:49 PM
fazek updated the diff for D1215: Wacom tablet crash in Krita.

@dkazakov, your idea worked perfectly! It solved the crash problem too. I also added the cleanup part, please check it.

Mar 25 2016, 10:57 AM
fazek closed D1199: Krita: patch for a crash during document close.
Mar 25 2016, 9:05 AM
fazek committed R37:8fef07fc4906: D1199 patch for a crash during document close (authored by fazek).
D1199 patch for a crash during document close
Mar 25 2016, 9:05 AM

Mar 24 2016

fazek closed T1910: Tile management changes as Invalid.
Mar 24 2016, 8:02 PM · Krita: 3.0 bugs sprint
fazek placed T1835: Deevad's data loss when COMPOSITE COPY up for grabs.
Mar 24 2016, 8:01 PM · Krita: 3.0 bugs sprint
fazek closed D1177: Krita: set infinite timeline after loading a file.
Mar 24 2016, 8:00 PM
fazek closed D1184: Viewing cache-missed animation frames too.
Mar 24 2016, 7:59 PM
fazek updated the test plan for D1215: Wacom tablet crash in Krita.
Mar 24 2016, 5:10 PM
fazek retitled D1215: Wacom tablet crash in Krita from to Wacom tablet crash in Krita.
Mar 24 2016, 5:09 PM
fazek closed D1196: Krita import animation frames: remaining tiles in the memory.
Mar 24 2016, 4:08 PM
fazek committed R37:a2bc8947bd81: D1196 Import animation frames: remaining tiles in the memory (authored by fazek).
D1196 Import animation frames: remaining tiles in the memory
Mar 24 2016, 4:07 PM
fazek added a comment to D1196: Krita import animation frames: remaining tiles in the memory.

Never mind, the leak still happened without this, so I commit and close it.

Mar 24 2016, 4:05 PM
fazek added a comment to D1196: Krita import animation frames: remaining tiles in the memory.

@rempt I still have the original code here. Is there already a different solution for this?

Mar 24 2016, 3:50 PM

Mar 23 2016

fazek added a reviewer for D1199: Krita: patch for a crash during document close: dkazakov.
Mar 23 2016, 6:24 PM
fazek committed R37:09f9c6b023ef: Hide the splashscreen while viewing the autosave recovery dialog (authored by fazek).
Hide the splashscreen while viewing the autosave recovery dialog
Mar 23 2016, 5:50 PM
fazek committed R37:da174dc3762d: D1177: Krita: set infinite timeline after loading a file (authored by fazek).
D1177: Krita: set infinite timeline after loading a file
Mar 23 2016, 5:01 PM
fazek committed R37:f54a6a6f636e: D1184: Viewing cache-missed animation frames too (authored by fazek).
D1184: Viewing cache-missed animation frames too
Mar 23 2016, 4:59 PM
fazek added a comment to D1184: Viewing cache-missed animation frames too.

If you look closely the difference between these that when the cache exists and there is no frame to view (cache miss), the original version does nothing, but the new one goes to the joined else case and view the frame without the cache. If the frame is not in the cache, it only starts to render if no another rendering in progress. The problem was that when the frame is not ready the program never shows it (even if it's ready later), so you see the last viewed frame. It's really annoying when you scrub on the timeline frame by frame with the mouse.

Mar 23 2016, 4:48 PM
fazek abandoned D1195: Tile management with shared pointers instead of reference counting.

I've found nothing. it seems the original version works perfectly. so now I abandon this revision, I hope these still remain here for the archive.

Mar 23 2016, 4:37 PM
fazek updated the diff for D1199: Krita: patch for a crash during document close.

So I figured out what is the problem here. The animation interface is part of the private structure of KisImage. But when destroying the image, first its root layer destroyed, and only after that comes the private structure with the animation interface. But if the animation interface has a work in progress, it's possibly wants to use the root layer after it removed. It seems the animation interface is not what waitForDone() waiting for. I decided to create the animation interface after the rootlayer created, and to delete it before the rootlayer deleted. I think this is the clear solution.

Mar 23 2016, 8:16 AM
fazek added a comment to D1199: Krita: patch for a crash during document close.

I see now when this happens easily. If you modify the animation, after some idle time the program starts building the cache. If you close the document during this, it has a high probability to crash.

Mar 23 2016, 7:06 AM

Mar 22 2016

fazek updated the diff for D1199: Krita: patch for a crash during document close.

Update: It's strange but sometimes only the root pointer is null... I really hope this is not about threading again...

Mar 22 2016, 6:46 PM
fazek retitled D1199: Krita: patch for a crash during document close from to Krita: patch for a crash during document close.
Mar 22 2016, 6:25 PM
fazek added a comment to T1916: Wrong colors in OpenGL accelerated animation playback.

The cache is not color managed probably to increase the rendering speed. The playback in CMYK space is pure garbage, I think because of the extra colour channel. But CMYK has no meaning in the film industry. XYZ space can be important for cinema quality animations (DCP) . What is the best solution then, to add a color space conversion ?

Mar 22 2016, 12:26 PM · Krita: 3.0 bugs sprint
fazek retitled D1196: Krita import animation frames: remaining tiles in the memory from to Krita import animation frames: remaining tiles in the memory.
Mar 22 2016, 9:20 AM
fazek committed R37:a38e978015f2: Removed the addKeyframe calls before importFrame (authored by fazek).
Removed the addKeyframe calls before importFrame
Mar 22 2016, 8:47 AM
fazek added a comment to T1916: Wrong colors in OpenGL accelerated animation playback.

A possible solution I think, to use the cache only if the color space matches enough (ie. it's well usable in all RGB spaces with minor color distortions) and to use the cacheless redrawing otherwise.

Mar 22 2016, 5:35 AM · Krita: 3.0 bugs sprint

Mar 21 2016

fazek created T1916: Wrong colors in OpenGL accelerated animation playback.
Mar 21 2016, 7:17 PM · Krita: 3.0 bugs sprint
fazek updated the diff for D1184: Viewing cache-missed animation frames too.

Update: I figured out that the loop is a possible deadlock, because the OpenGL cache rejects the new rendering if there is already a rendering in progress. So I reverted this back to its first version, only removed the warning message handling because there is no message at all.

Mar 21 2016, 7:08 PM
fazek updated subscribers of R37:8787c0528933: Tile data: recursive QMutex to avoid deadlocks.

@rempt already reverted these commits and I made a differential with a modified version: D1195

Mar 21 2016, 5:59 PM
fazek retitled D1195: Tile management with shared pointers instead of reference counting from to Tile management with shared pointers instead of reference counting.
Mar 21 2016, 5:40 PM
fazek added a comment to R37:8fbee3ee05cd: Revert "Tile data: recursive QMutex to avoid deadlocks".

Thanks, I'm making a different solution now.

Mar 21 2016, 1:57 PM
fazek added a comment to R37:8787c0528933: Tile data: recursive QMutex to avoid deadlocks.

The problem here is the destructor of the TileData which locks the mutex. It happens when the last QSharedPointer reference to the tile destroyed, sometimes it happens between KisTileDataStore::beginIteration() and endIteration() which also locks it. I agree it's bad so I have to use the KisTileDataSP type for the KisTileDataList to avoid this.

Mar 21 2016, 1:56 PM
fazek created T1910: Tile management changes.
Mar 21 2016, 1:33 PM · Krita: 3.0 bugs sprint
fazek added a comment to T1835: Deevad's data loss when COMPOSITE COPY.

@dkazakov: the commit was related to the multi-thread access of the tiles. The behaviour of the Composite Copy bug looks similar to this bug, but of course there can be another reason. Sorry if it's not related, I move it to a different topic then.

Mar 21 2016, 1:26 PM · Krita: 3.0 bugs sprint
fazek committed R37:8787c0528933: Tile data: recursive QMutex to avoid deadlocks (authored by fazek).
Tile data: recursive QMutex to avoid deadlocks
Mar 21 2016, 12:54 PM
fazek added a comment to T1835: Deevad's data loss when COMPOSITE COPY.

Committed my solution into master.

Mar 21 2016, 11:00 AM · Krita: 3.0 bugs sprint
fazek committed R37:bb523df64b47: Tile data management with QSharedPtr instead of reference count (T1835) (authored by fazek).
Tile data management with QSharedPtr instead of reference count (T1835)
Mar 21 2016, 10:58 AM

Mar 20 2016

fazek added a comment to T1835: Deevad's data loss when COMPOSITE COPY.

So my opinion is this: the KisTileData::ref() and deref() functions are not thread safe. I made a test and it seems these are actually callled from the tile creator thread and from other threads too (probably that's why the atomic ref() used here). A worst case scenario could be like this:

Mar 20 2016, 2:21 PM · Krita: 3.0 bugs sprint
fazek updated the diff for D1184: Viewing cache-missed animation frames too.

I updated the code to the signal handling version. I can't decide which one is better. This takes half computing time but it is a deadlock if somehow the frame not appearing into the cache.

Mar 20 2016, 6:32 AM

Mar 19 2016

fazek retitled D1184: Viewing cache-missed animation frames too from to Viewing cache-missed animation frames too.
Mar 19 2016, 7:57 PM
fazek added a comment to T1835: Deevad's data loss when COMPOSITE COPY.

I don't know but I see some problems in the kis_tile_... part too. Maybe not related to this bug and maybe it causes problems only once in a decade, but still.

Mar 19 2016, 3:32 PM · Krita: 3.0 bugs sprint
fazek added a comment to T1835: Deevad's data loss when COMPOSITE COPY.

I'm trying to solve this. My suspect the is the atomic int ref() - deref(), it is not safe enough (see the KisTileData::deref() function as an example), since it is theoretically possible for a different thread to ref() a tile between the deref() function and the actual erasing (freeTileData()). But this is very unlikely, so perhaps there are other problems too.

Mar 19 2016, 2:57 PM · Krita: 3.0 bugs sprint
fazek claimed T1835: Deevad's data loss when COMPOSITE COPY.
Mar 19 2016, 2:50 PM · Krita: 3.0 bugs sprint
fazek retitled D1177: Krita: set infinite timeline after loading a file from to Krita: set infinite timeline after loading a file.
Mar 19 2016, 10:17 AM

Mar 18 2016

fazek added a comment to D1166: BUG:360677 KisUpdaterContext should not kill threads in waitForDone().

Just an idea: perhaps it's not a big problem, but this is a cpu hungry solution. You could wait for the threads one by one, always for a single thread to finish. Then you can do it with something like pthread_join() or QThread::wait(), I don't know how the threads are implemented.

Mar 18 2016, 12:09 PM
fazek added a comment to T1858: Hangup when closing Krita 3.0.

Not really a hangup but I get segfault very often when closing Krita (perhaps malloc corruption). It's just not really noticable, only a final message on the terminal. Also often it says there are remaining tiles in the memory, whatever it means.

Mar 18 2016, 4:59 AM · Krita: 3.0 bugs sprint

Mar 16 2016

fazek added a comment to T1808: Random assert while animating..

I'm trying to reproduce this bug, yet without success.
But I got this message once while animating:

Mar 16 2016, 2:37 PM · Krita: 3.0 bugs sprint, Krita: Old Dmitry's Workboard (not used anymore), Krita, Krita: Animation
fazek committed R37:8fa80026d61e: CSV export patch to avoid crash when a layer has no animation (authored by fazek).
CSV export patch to avoid crash when a layer has no animation
Mar 16 2016, 1:43 PM

Mar 14 2016

fazek added a comment to R37:c17ed2740971: Patch for the Bug 352869 shade selector indicator.

I have a problem with Krita now... after pulled your commit c17ed27409710a87cea1e7f74015873967095baf, it seems the program uses 100% CPU even in idle after startup, without any documents. As I see it refreshes the KisShadeSelectorLine widget again and again without any reason.

Mar 14 2016, 3:06 PM
fazek committed R37:2a4960f096d9: Correct reply for file dialog cancel in animation exporter (authored by fazek).
Correct reply for file dialog cancel in animation exporter
Mar 14 2016, 8:31 AM

Mar 13 2016

fazek closed D1074: Krita: Blur glitch fix.

Pushed to git.

Mar 13 2016, 5:48 PM
fazek committed R37:2a6b9861c95d: Glitch fix for blur modes (D1074) (authored by fazek).
Glitch fix for blur modes (D1074)
Mar 13 2016, 5:37 PM

Mar 11 2016

fazek added a comment to D1097: Progressbar related modifications in Krita.

Thank you :)

Mar 11 2016, 10:40 AM
fazek updated the diff for D1074: Krita: Blur glitch fix.

I made some more tests. GNU c++ knows the difference between (a < b) and (!(a >= b)) so I added an extra modification in the limitValue() to filter out any remaining NaNs. Interesting that this modification alone solves the original problem. But since I'm not sure what happens in other compilers, it's safer to keep the original alphaValue test solution too, just I changed it to the epsilon version.

Mar 11 2016, 9:32 AM

Mar 10 2016

fazek closed D1097: Progressbar related modifications in Krita.

Added the missing error messages and pushed it to master. This was my first git push to Krita by myself, so I hope it landed correctly.

Mar 10 2016, 8:09 PM
fazek committed R37:6e273157be9a: Progressbar related modifications in Krita New features: (authored by fazek).
Progressbar related modifications in Krita New features:
Mar 10 2016, 8:04 PM
fazek added a comment to D1074: Krita: Blur glitch fix.

First I used the (alphaValue > 0) version but then I was curious what happens here. But the epsilon version is better. We could add extra safety with tricky comparisons as well (and maybe it's worth to search for other occurences in the code):

Mar 10 2016, 12:40 PM