Differential D2822

Krita: mouse wheel on the timeline
AbandonedPublic
Actions

Authored by fazek on Sep 20 2016, 7:12 PM.

Details

Reviewers
dkazakov
jounip
Group Reviewers
Krita
Summary

This patch adds mouse wheel support for the animation timeline widget. I just copied some code from the slotDataChanged() part but I'm not sure how important to check dragInProgress here.

Test Plan

Create animation and move the mouse over the timeline. Now you can step the timeline cursor horizontally with the mouse wheel.

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
fazek updated this revision to Diff 6838.Sep 20 2016, 7:12 PM
fazek retitled this revision from to Krita: mouse wheel on the timeline.
fazek updated this object.
fazek edited the test plan for this revision. (Show Details)
fazek added a reviewer: Krita.
fazek set the repository for this revision to R37 Krita.
fazek added a subscriber: fazek.
rempt added reviewers: jounip, dkazakov.Sep 21 2016, 7:45 AM
rempt added a subscriber: rempt.

Added Jouni and Dmitry as reviewers.

fazek added a comment.Sep 21 2016, 8:17 AM

I just have an idea for some improvement, but not checked if it's possible:
this is horizontal movement now, maybe shift+wheel could be the vertical, if more than one layer is visible. Ctrl+wheel is nicely working to select a range of frames (at least on Linux).

fazek added a comment.Sep 29 2016, 8:06 AM

After one week of no answer, I tried to implement the shift+wheel vertical positioning. It's not useful because of the nature of the timeline and how it's showing and hiding the layers. I think it's better not to add it. The original version seems working fine, so I'm not waiting for the revision and committed it to master.

fazek abandoned this revision.Sep 29 2016, 8:07 AM

Revision Contents
Changeset List

Diff 6838

View Options

plugins/dockers/animation/timeline_frames_view.h

Loading...
View Options

plugins/dockers/animation/timeline_frames_view.cpp

Loading...