| rempt |
New features:
todo: a new error message type for the canceled file operations (now cancels with OK).
| Lint Skipped |
| Unit Tests Skipped |
I wonder if in the future we'll manage to figure out a way to make the eventloop hackery common to all filters, but the patch is looking good and a nice simplification of the KisDocument code.
Added the missing error messages and pushed it to master. This was my first git push to Krita by myself, so I hope it landed correctly.
The commit landed without problems. Well, one thing: you don't build the tests, I think, so you forgot to also rename the startExport to exportAnimation in the animation export unittest.
But just a hint for the commit message:
Have a one-line title, not longer than 80 characters
Then one blank line
Then the larger message
That's how git expects commit messages to be formatted, and some git log features depend on that being correct.
Thank you :)
I'm using command line git and just copied the text from here into the terminal....
Isn't there a way to push a diff directly from the phabricator after it's accepted?
Yes, I think that's possible. But also check https://techbase.kde.org/Development/Git/Configuration for configuring git and commit templates.