Looks mostly good to me, the main comments are 1) move some roto related functions out of the keyframe class 2) don't break keyframemodellist interface.

See https://community.kde.org/Infrastructure/Phabricator#Workflow. You can use arc land or git push if you don't need to squash

Thanks for the diff, it looks good to me, minus some small details that I pointed out inline.

Well if you called called requestClipInsertion, then you got back the id of the clip you just added. Then the clipModel has a getPlaytime() method that do what you want. I see that there is no direct getter for the length in the timeline class (there is one for position though, getClipPosition), but you can create your own getter for that on the same model.

LGTM. Please note that we have a .clang-format file in the top directory to help you format your code (I can spot some extra spaces here and there :p )

Well actually, you probably need a helper function to add several clips consecutively starting from a given (track, position). The right place to implement this is TimelineFunctions. The signature should be along the lines of

static bool requestAddMultipleClips(std::shared_ptr<TimelineItemModel> timeline, const std::vector<int>& binIds, QList<int>& clipIds);

where cliIpIds is a return parameter of the ids of the created clips (if successful). This function repeatedly call requestClipInsertion (the version with undo/redo), unless a conflict is found.

Not directly. The code you are writing will probably be sitting in the timeline qml, and you don't have direct access to groupmodel from there (it is not advisable anyways to access it directly). Rather use requestClipsGroup/requestClipsUngroup from timelineModel.

@boiko sounds good. You have to insert clips using the appropriate function of the timelinemodel, and then group them while the user is dragging (to make sure they all move together) and finally ungroup when the user release them. Let me know if anything goes wrong

I'm probably the one to blame for both issues there :)

@afarid It should be separate, since they are going to be 2 different things. Note that currently we only have compositions, so no bug expected in that category (yet :) )

Wow, this looks great, thanks for the effort you put into this.

Hi,
Thank you for sharing this.
As for the icons themselves, they look fine to me. Your take on rolling is a bit unconventional, but I think it conveys the right meaning, what do you guys think?