• copy/paste clips not working
• favourites effects dont work, nor you can drag them
• effects:
  • missing effects: No transform?
  • effects without variables:
    • position and zoom
    • rotate
  • favourites not working
  • no contextual menu
• length of the project? where is defined.? colored tracks go up to 10' instead of using the last clip on track as size of the project

Hi

Could you guys please let me know which items you are working on? I would like to help on these blocker items but want to avoid duplicated efforts.

I would like to know more about the "project duration" item, is it just wrongly calculated or what is the problem exactly?

Thanks

So, I will try to fix the "Insert several clips" item, ok?

@boiko sounds good. You have to insert clips using the appropriate function of the timelinemodel, and then group them while the user is dragging (to make sure they all move together) and finally ungroup when the user release them. Let me know if anything goes wrong

In T7128#117985, @alcinos wrote:

@boiko sounds good. You have to insert clips using the appropriate function of the timelinemodel, and then group them while the user is dragging (to make sure they all move together) and finally ungroup when the user release them. Let me know if anything goes wrong

Thank you for the hints. Just to make sure I am following the correct route: I should use the instance of GroupsModel to group the items right after they are created, correct?

Not directly. The code you are writing will probably be sitting in the timeline qml, and you don't have direct access to groupmodel from there (it is not advisable anyways to access it directly). Rather use requestClipsGroup/requestClipsUngroup from timelineModel.

In T7128#117988, @alcinos wrote:

Not directly. The code you are writing will probably be sitting in the timeline qml, and you don't have direct access to groupmodel from there (it is not advisable anyways to access it directly). Rather use requestClipsGroup/requestClipsUngroup from timelineModel.

Got it. My plan was to handle that inside requestClip{Insertion,Creation} but I guess it makes more sense to do that from the QML side indeed (to handle the ungrouping), let me try it this way.

Well actually, you probably need a helper function to add several clips consecutively starting from a given (track, position). The right place to implement this is TimelineFunctions. The signature should be along the lines of

static bool requestAddMultipleClips(std::shared_ptr<TimelineItemModel> timeline, const std::vector<int>& binIds, QList<int>& clipIds);

where cliIpIds is a return parameter of the ids of the created clips (if successful). This function repeatedly call requestClipInsertion (the version with undo/redo), unless a conflict is found.

Then you handle grouping/ungrouping from the dropArea in QML (timeline.qml:194)

Hope this makes sense.

@alcinos It does make sense. I got a bit lost in all those timeline classes, but soon they will be familiar :)

@alcinos one more question: So, I insert the first clip, and in order to insert the next one I need to adjust the position accordingly. How can I do that? I mean, how can I fetch the duration of the clip I just added in order to increment the position

Thanks

Well if you called called requestClipInsertion, then you got back the id of the clip you just added. Then the clipModel has a getPlaytime() method that do what you want. I see that there is no direct getter for the length in the timeline class (there is one for position though, getClipPosition), but you can create your own getter for that on the same model.

Note that there is also a way to retrieve a pointer to the clip (getClipPtr), but beware that you should only ever call getters of the clip, not try to modify it directly. For example, do NOT try to call directly ClipModel::requestResize (this should only be called from the appropriate function(s) of the TimelineModel)

Hi, I see that "Insert several clips" is marked as done, is that counting on my changes or was that already done by someone else?
I am asking just to know if my branch is still relevant (I basically addressed all the comments, just didn't have the time yet to write tests) or if I should close/remove it.