Use the thumb producer form project clip in ThumbJob

Authored by boiko on Nov 14 2017, 12:20 AM.



Update the ProjectClip::thumbProducer to be a std::shared_ptr and use it in the

Using the originalProducer() causes crashes when using movit acceleration.

Test Plan
  • Enable movit
  • Run kdenlive
  • Add a JPEG image to the project bin

Diff Detail

R158 Kdenlive
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
boiko created this revision.Nov 14 2017, 12:20 AM

LGTM. Please note that we have a .clang-format file in the top directory to help you format your code (I can spot some extra spaces here and there :p )

alcinos accepted this revision.Nov 17 2017, 5:27 PM
This revision is now accepted and ready to land.Nov 17 2017, 5:27 PM
mardelle accepted this revision.Nov 21 2017, 9:18 PM

Thanks a lot for your work. Do you have commit access to push your change ?

I think I do have commit access, I never used phabricator before so I was not sure if I had to merge manually, or if it had a "Merge" button like github does.

So how does merging works? Should I just use git to push the changes or do I have to use arc? Sorry, I have never used phabricator before, still learning how things work here.

See You can use arc land or git push if you don't need to squash

This revision was automatically updated to reflect the committed changes.