• Move the multiple clip insertion to TimelineFunctions
• Use the GroupType::Selection when grouping clips while inserting
• Remove unused group ID from QML.

• Remove unused group ID from QML.

• Move the multiple clip insertion to TimelineFunctions
• Use the GroupType::Selection when grouping clips while inserting

In D8928#211373, @mardelle wrote:

Oh, my bad sorry. I should have given some feedback on this diff. Since I was rather stressed with the perspective of a 18.04 launch and there was no activity on this since november, I fixed the problem in this commit on the 2nd of february :
https://cgit.kde.org/kdenlive.git/commit/?h=refactoring_timeline&id=5ecd42394298cad227613e2db4711fa837f148c0

Hi, I see that "Insert several clips" is marked as done, is that counting on my changes or was that already done by someone else?
I am asking just to know if my branch is still relevant (I basically addressed all the comments, just didn't have the time yet to write tests) or if I should close/remove it.

• Move the multiple clip insertion to TimelineFunctions

• Merge branch 'refactoring_timeline' of git://anongit.kde.org/kdenlive
• Merge branch 'refactoring_timeline' of git://anongit.kde.org/kdenlive into drag_multiple
• Move the multiple clip insertion to TimelineFunctions

I think I do have commit access, I never used phabricator before so I was not sure if I had to merge manually, or if it had a "Merge" button like github does.

I will fix the unordered_set instantiation and add unit tests, thanks for reviewing.

@alcinos one more question: So, I insert the first clip, and in order to insert the next one I need to adjust the position accordingly. How can I do that? I mean, how can I fetch the duration of the clip I just added in order to increment the position

@alcinos It does make sense. I got a bit lost in all those timeline classes, but soon they will be familiar :)

In T7128#117988, @alcinos wrote:

Not directly. The code you are writing will probably be sitting in the timeline qml, and you don't have direct access to groupmodel from there (it is not advisable anyways to access it directly). Rather use requestClipsGroup/requestClipsUngroup from timelineModel.

In T7128#117985, @alcinos wrote:

@boiko sounds good. You have to insert clips using the appropriate function of the timelinemodel, and then group them while the user is dragging (to make sure they all move together) and finally ungroup when the user release them. Let me know if anything goes wrong

So, I will try to fix the "Insert several clips" item, ok?

Could you guys please let me know which items you are working on? I would like to help on these blocker items but want to avoid duplicated efforts.

Changing it to use the thumbProducer did the trick, thanks for the hint.
I have sent a phabricator differential, but bear with me as it is my first time using phabricator :)

So, any hints on where/what/how I could debug that? I can certainly dig the code myself, but any pointers on exactly what could have caused it would speed things up :)

Using latest kdenlive from refactoring_timeline, when I try to add a JPEG file to the project bin, I get a crash with the following backtrace:
https://paste.kde.org/phutyhwd7