a clean update to match the revision summeary

In D8471#160846, @stelioss wrote:

In D8471#160775, @stelioss wrote:

two local commits remain to be signed

I reset to origin/master discarding all of my commits and committed only three changes:
the one that fixes the warning, the explicit constructors and the spelling corrections.
At least now it looks clean: one commit with correct credentials

In D8471#160775, @stelioss wrote:

two local commits remain to be signed

two local commits remain to be signed

In D8471#160638, @rizzitello wrote:

They don't need to be kde.org email and the name doesn't have to match the
emails but you do need first and last name. You do need to sign the commit
with git commit -s --amend.

In D8471#160611, @rizzitello wrote:

In D8471#160610, @stelioss wrote:

In D8471#160376, @rizzitello wrote:

In D8471#160169, @stelioss wrote:

• empty lines at the end removed
  
  diff updated
  
  I'll try to solve the conflicts I've got invoking 'git pull'

Don't worry about that i will do it durring landing . just be sure your gitname and git email are valid to avoid landing errors.

yes, user.name and user.email are in .gitconfig now

I still get the same error . As described by lays above you need to add a real name (first and last). For your email please use the same as you use for your identity mail. If the current mail is your identity mail (and as you said its varified ) we may have a bug there due to the uncommon domain postfix, that might need a sysadmin ticket to fix.

Non-full name
Email address has an invalid domain

In D8471#160376, @rizzitello wrote:

In D8471#160169, @stelioss wrote:

• empty lines at the end removed
  
  diff updated
  
  I'll try to solve the conflicts I've got invoking 'git pull'

Don't worry about that i will do it durring landing . just be sure your gitname and git email are valid to avoid landing errors.

• empty lines at the end removed

In D8471#160113, @rizzitello wrote:

It's possible. I'm not sure why

In D8471#160110, @rizzitello wrote:

It Seams I am not able to land your patch either but for different reasons. i get two errors for each of your commits

remote: Audit failure - Commit 921e0504b54b9ddbdf7ddb3fdd44745093fc684f - Non-full name: NAMEUSED
remote: Audit failure - Commit 921e0504b54b9ddbdf7ddb3fdd44745093fc684f - Email address has an invalid domain : YOUREMAIL

In D8471#159993, @laysrodrigues wrote:

Please merge it =D

• empty lines at the end removed

In krazy2 analysis, it seemw a lot of things that appear as issues are either not important or non-issues

• json files are now empty, consistency in cpp files for own header is checked

• D8471 changes reverted in six files