In D8471#159993, @laysrodrigues wrote:

Please merge it =D

I am not sure I can. I cloned it from anongit URL and now running 'arc land' gives a fatal :
The requested URL returned error: 403

In D8471#160098, @stelioss wrote:

In D8471#159993, @laysrodrigues wrote:

Please merge it =D

I am not sure I can. I cloned it from anongit URL and now running 'arc land' gives a fatal :
The requested URL returned error: 403

Alright i've got you this time.

It Seams I am not able to land your patch either but for different reasons. i get two errors for each of your commits

remote: Audit failure - Commit 921e0504b54b9ddbdf7ddb3fdd44745093fc684f - Non-full name: NAMEUSED
remote: Audit failure - Commit 921e0504b54b9ddbdf7ddb3fdd44745093fc684f - Email address has an invalid domain : YOUREMAIL

In D8471#160110, @rizzitello wrote:

It Seams I am not able to land your patch either but for different reasons. i get two errors for each of your commits

remote: Audit failure - Commit 921e0504b54b9ddbdf7ddb3fdd44745093fc684f - Non-full name: NAMEUSED
remote: Audit failure - Commit 921e0504b54b9ddbdf7ddb3fdd44745093fc684f - Email address has an invalid domain : YOUREMAIL

is it because I haven't verify my email address?

It's possible. I'm not sure why

In D8471#160113, @rizzitello wrote:

It's possible. I'm not sure why

OK, verified. You may retry, if you wish
Also my working copy is not associated with any repository

@stelioss I think that you didnt made the git setup on your machine:
git config -- global user.name and git config --global user.email
You need that configured so you can make the signature on your commits.
Check this link: https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup

After you correct your name to have both a first and last and your email to be a vaild one (with in git) you will neeed to update the commit
git commit -s --amend should now show the new info and -s will add a signature all commits need to be signed. when that is done update this diff. And I can do the rest.

In D8471#160169, @stelioss wrote:

• empty lines at the end removed
  
  diff updated
  
  I'll try to solve the conflicts I've got invoking 'git pull'

Don't worry about that i will do it durring landing . just be sure your gitname and git email are valid to avoid landing errors.

In D8471#160376, @rizzitello wrote:

In D8471#160169, @stelioss wrote:

• empty lines at the end removed
  
  diff updated
  
  I'll try to solve the conflicts I've got invoking 'git pull'

Don't worry about that i will do it durring landing . just be sure your gitname and git email are valid to avoid landing errors.

yes, user.name and user.email are in .gitcomfig now

In D8471#160610, @stelioss wrote:

In D8471#160376, @rizzitello wrote:

In D8471#160169, @stelioss wrote:

• empty lines at the end removed
  
  diff updated
  
  I'll try to solve the conflicts I've got invoking 'git pull'

Don't worry about that i will do it durring landing . just be sure your gitname and git email are valid to avoid landing errors.

yes, user.name and user.email are in .gitcomfig now

I still get the same error . As described by lays above you need to add a real name (first and last). For your email please use the same as you use for your identity mail. If the current mail is your identity mail (and as you said its varified ) we may have a bug there due to the uncommon domain postfix, that might need a sysadmin ticket to fix.

Non-full name
Email address has an invalid domain

In D8471#160611, @rizzitello wrote:

In D8471#160610, @stelioss wrote:

In D8471#160376, @rizzitello wrote:

In D8471#160169, @stelioss wrote:

• empty lines at the end removed
  
  diff updated
  
  I'll try to solve the conflicts I've got invoking 'git pull'

Don't worry about that i will do it durring landing . just be sure your gitname and git email are valid to avoid landing errors.

yes, user.name and user.email are in .gitconfig now

I still get the same error . As described by lays above you need to add a real name (first and last). For your email please use the same as you use for your identity mail. If the current mail is your identity mail (and as you said its varified ) we may have a bug there due to the uncommon domain postfix, that might need a sysadmin ticket to fix.

Non-full name
Email address has an invalid domain

although not so uncommon, possibly it needs a kde.org domain to make it valid?
Should the first last names in .gitconfig be identical to the first last names that are associated with the email address?
Because now they are not and I can fix that if necessary
Now I receive your phabricator comments in my email

They don't need to be kde.org email and the name doesn't have to match the
emails but you do need first and last name. You do need to sign the commit
with git commit -s --amend.

In D8471#160638, @rizzitello wrote:

They don't need to be kde.org email and the name doesn't have to match the
emails but you do need first and last name. You do need to sign the commit
with git commit -s --amend.

I signed it.
Initially I've made three commits.
Now the last one is signed correctly (I'll check for the rest)
and there is a list of modified files in the local repo.
About the 'own header first', commit, I did it because ebn said so but I can discard it, if you prefer.

two local commits remain to be signed

In D8471#160775, @stelioss wrote:

two local commits remain to be signed

I reset to origin/master discarding all of my commits and committed only three changes:
the one that fixes the warning, the explicit constructors and the spelling corrections.
At least now it looks clean: one commit with correct credentials

In D8471#160846, @stelioss wrote:

In D8471#160775, @stelioss wrote:

two local commits remain to be signed

I reset to origin/master discarding all of my commits and committed only three changes:
the one that fixes the warning, the explicit constructors and the spelling corrections.
At least now it looks clean: one commit with correct credentials

I didn't merge as lays suggested, I made things complicated instead
because I was not sure about the correctness of the changes I discarded later.