Feed Advanced Search

Dec 26 2018

gepardo added a comment to D17154: Go back to SCSS.

Also, overwriting sources is a no-no. :/

If this is a pre-existing bug, perhaps we should fix it in another patch though.

Dec 26 2018, 5:25 PM · Plasma
gepardo added a comment to D17154: Go back to SCSS.

It seems to be the issue with parallel Make. The original scripts often overwrite sources, so they can't be built in parallel. I'll try to fix it to resolve the race conditions.

Dec 26 2018, 4:25 PM · Plasma

Dec 25 2018

gepardo added a comment to R857:63d16727883e: Include a 'sass' compatible tool within the CI Images. While i'd prefer not to….

Because from what I could see, sassc wasn't available from the OpenSUSE repositories.

Dec 25 2018, 9:56 AM
gepardo added a comment to R857:63d16727883e: Include a 'sass' compatible tool within the CI Images. While i'd prefer not to….

Why are you using npm for this? There is sassc which is a compiled binary and doesn't have many dependencies.

Dec 25 2018, 9:35 AM

Dec 24 2018

gepardo updated the diff for D17154: Go back to SCSS.

Add gtk-dark.css support for Breeze

Dec 24 2018, 9:05 PM · Plasma
gepardo updated the diff for D17154: Go back to SCSS.

Fix GTK+ 3.18 theme installation

Dec 24 2018, 8:49 PM · Plasma
gepardo added a comment to D17154: Go back to SCSS.

Oops, sorry, I forgot to check the installation.

Dec 24 2018, 8:45 PM · Plasma
gepardo updated the diff for D17154: Go back to SCSS.

Fix finding Python package for CMake <3.12

Dec 24 2018, 7:32 PM · Plasma
gepardo added inline comments to D17154: Go back to SCSS.
Dec 24 2018, 7:30 PM · Plasma
gepardo updated the diff for D17154: Go back to SCSS.

Make Sass a required dependency

Dec 24 2018, 7:01 PM · Plasma

Dec 22 2018

gepardo updated the diff for D17154: Go back to SCSS.

More improvements:

Dec 22 2018, 8:51 PM · Plasma
gepardo updated the diff for D17154: Go back to SCSS.

Use CMake for building themes

Dec 22 2018, 8:42 PM · Plasma
gepardo added a comment to D17154: Go back to SCSS.

On that subject, rebuilding the theme should be done as a part of the default build target when running make rather than requiring the use of a script. It's a requirement that all the work gets done simply by running make. This will require a few CMake adjustment too.

Dec 22 2018, 7:55 PM · Plasma

Dec 9 2018

gepardo updated the diff for D17464: [Timer applet] Minor fixes for the applet.

Add a comment about value 0.77

Dec 9 2018, 10:39 PM · Plasma
gepardo added inline comments to D17464: [Timer applet] Minor fixes for the applet.
Dec 9 2018, 10:35 PM · Plasma
gepardo added inline comments to D17464: [Timer applet] Minor fixes for the applet.
Dec 9 2018, 10:24 PM · Plasma
gepardo added inline comments to D17464: [Timer applet] Minor fixes for the applet.
Dec 9 2018, 10:13 PM · Plasma
gepardo requested review of D17464: [Timer applet] Minor fixes for the applet.
Dec 9 2018, 9:48 PM · Plasma
gepardo added a comment to D17154: Go back to SCSS.

This patch is not reviewed for two weeks. How soon can I get some feedback on it?

Dec 9 2018, 8:43 PM · Plasma

Nov 25 2018

gepardo requested review of D17154: Go back to SCSS.
Nov 25 2018, 12:38 PM · Plasma

Aug 30 2018

gepardo added a comment to D15110: Fix scrollbars in LibreOffice.

@davidedmundson, can you please merge this revision? I don't have a developer account, so I can't do it.

Aug 30 2018, 4:46 AM · Plasma

Aug 28 2018

gepardo added a comment to D15110: Fix scrollbars in LibreOffice.

Can you explain where this 14 is derived from?

Aug 28 2018, 9:46 AM · Plasma
gepardo requested review of D15110: Fix scrollbars in LibreOffice.
Aug 28 2018, 5:08 AM · Plasma