Now it looks like this:

Instead of showing colorful rectangles, use same icons as for annotation tool

In D21364#469215, @davidhurka wrote:

In D21364#469159, @jangmarker wrote:

I think captionForAnnotation() does not include the comment's text currently, so this change should probably be done in another commit.

It would make sense to show icons to indicate the annotation type, e.g. a different icon for highlight, freehand lines, underlines etc. And if these were colored according to the annotation's color, that would be perfect IMO.

That’s what I meant. :)

In D21364#469111, @davidhurka wrote:

Nice, makes the list more intuitive. :) (Didn’t test this)

Thank you :-) Currently it looks like this:

Nice :-)
Can we integrate that with arc?

There was an issue with phabricator, it created a patch from something it shouldn't use.
Ignore Patch 3

Use correct patch

the commit which closed this revision was not development/qmlweb2

[Compiler] Fix issues pointed out in review

thanks

thank you :-) maybe that structure will last forever :D

please fix the added inline commit, everything else is ready to go

great :-)

Thanks for that work and the thousand revamps, I like it's shape very much.

It's abut testability and data encapsulation: global objects are hard to mock (i.e. change their behaviour) when testing.

I think this is a good chance to unify the headers of all files to:

• not contain a <this line describes the files purpose> line
• check for other inconsistencies