[Compiler] Add basic types and QtQml module.
ClosedPublic
Actions

Authored by akreuzkamp on Sep 11 2015, 11:02 AM.

Details

Reviewers

jangmarker
pavelvasev

Maniphest Tasks

Restricted Maniphest Task

Commits

Summary

Adds a module loader for the QtQml module and adds a static class that
provides all the built in types.

T488

Repository

R18 QMLWeb

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

akreuzkamp retitled this revision from to [Compiler] Add basic types and QtQml module..

akreuzkamp updated this object.

akreuzkamp edited the test plan for this revision. (Show Details)

akreuzkamp added a task: Restricted Maniphest Task.Sep 11 2015, 12:14 PM

akreuzkamp updated this object.

jangmarker requested changes to this revision.Sep 11 2015, 12:31 PM

jangmarker edited edge metadata.

jangmarker added inline comments.

src/qmljsc/moduleloading/javascriptmoduleloader.cpp
416–417	I'd prefer the variable name type instead of t
src/qmljsc/moduleloading/qtqmlmoduleloader.cpp
50	I'd prefer p -> property m -> method s -> signal
src/qmljsc/moduleloading/qtqmlmoduleloader.h
40	documentation needs update
tests/auto/qmljsc/testmodules.cpp
227	I'd prefer p => property m => method s => signal

This revision now requires changes to proceed.Sep 11 2015, 12:31 PM

Fixed docu and one variable name.

thanks

This revision is now accepted and ready to land.Sep 11 2015, 12:51 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/qmljsc/CMakeLists.txt (1 line)
P		src/qmljsc/ir/builtintypes.h (44 lines) Copied from src/qmljsc/moduleloading/qtqmlmoduleloader.h
A	M	src/qmljsc/ir/builtintypes.cpp (104 lines)
M		src/qmljsc/ir/typesystem.h (5 lines)
M		src/qmljsc/ir/typesystem.cpp (10 lines)
M		src/qmljsc/moduleloading/javascriptmoduleloader.cpp (14 lines)
P		src/qmljsc/moduleloading/qtqmlmoduleloader.h (4 lines) Copied to src/qmljsc/ir/builtintypes.h
M		src/qmljsc/moduleloading/qtqmlmoduleloader.cpp (91 lines)
M		tests/auto/data/imports/TestModule.0.1.js (1 line)
M		tests/auto/qmljsc/testir.cpp (42 lines)
M		tests/auto/qmljsc/testmodules.cpp (72 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	853	b42ccbb		Sep 11 2015, 11:02 AM	★	★
Diff 2	854	b42ccbb	Fixed docu and one variable name.	Sep 11 2015, 12:48 PM	★	★
Diff 3	855	b42ccbb	Commit rQMLWEB1a3d4c0a77f48a0bd8e8d19545fff5b75bee43bd	Sep 11 2015, 10:05 AM	★	★
Diff 4	856	1a3d4c0	Commit rQMLWEB15b31452e71d6d45a3aa0ade69647a620e9edd4c	Sep 11 2015, 12:51 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
15b31452e71d	c591b179f2ae	1a3d4c0a77f4	Anton Kreuzkamp	[Compiler] Move builtin types out of QtQml module.	Sep 11 2015, 10:34 AM
1a3d4c0a77f4	fb70d26c5732	b42ccbb2d269	Anton Kreuzkamp	[Compiler] Add module loader for QtQml.	Sep 9 2015, 4:05 PM