jangmarker (Jan Gerrit Marker)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Jul 12 2015, 6:41 AM (218 w, 6 d)
Availability
Available

Recent Activity

May 23 2019

jangmarker added inline comments to D21376: RFC: In annotations list show highlighted text.
May 23 2019, 11:27 PM · Okular
jangmarker added reviewers for D21376: RFC: In annotations list show highlighted text: Okular, davidhurka.
May 23 2019, 11:26 PM · Okular
jangmarker requested review of D21376: RFC: In annotations list show highlighted text.
May 23 2019, 11:26 PM · Okular
jangmarker added a comment to D21364: Indicate annotation color in annotation list.

Now it looks like this:

May 23 2019, 10:05 PM · Okular
jangmarker updated the diff for D21364: Indicate annotation color in annotation list.

Instead of showing colorful rectangles, use same icons as for annotation tool

May 23 2019, 10:02 PM · Okular
jangmarker added a comment to D21364: Indicate annotation color in annotation list.

I think captionForAnnotation() does not include the comment's text currently, so this change should probably be done in another commit.

It would make sense to show icons to indicate the annotation type, e.g. a different icon for highlight, freehand lines, underlines etc. And if these were colored according to the annotation's color, that would be perfect IMO.

That’s what I meant. :)

May 23 2019, 9:19 PM · Okular
jangmarker added a comment to D21364: Indicate annotation color in annotation list.

Nice, makes the list more intuitive. :) (Didn’t test this)

Thank you :-) Currently it looks like this:

May 23 2019, 8:24 PM · Okular
jangmarker added a reviewer for D21364: Indicate annotation color in annotation list: Okular.
May 23 2019, 12:23 PM · Okular
jangmarker requested review of D21364: Indicate annotation color in annotation list.
May 23 2019, 12:22 PM · Okular

Aug 8 2017

jangmarker committed R32:4905cd6252de: If name or email are empty add a place holder instead of nothing to the license (authored by jangmarker).
If name or email are empty add a place holder instead of nothing to the license
Aug 8 2017, 4:01 PM
jangmarker committed R32:38b93a39466f: Add year, name and email to license text when generating a new class. In order… (authored by jangmarker).
Add year, name and email to license text when generating a new class. In order…
Aug 8 2017, 4:01 PM

Sep 10 2016

jangmarker committed R108:44034f119939: Desktop grid effect now does not preserve space for windows from other… (authored by jangmarker).
Desktop grid effect now does not preserve space for windows from other…
Sep 10 2016, 6:05 AM
jangmarker committed R108:35cdd8fa222b: Make present windows effect not preserve space for windows from other… (authored by jangmarker).
Make present windows effect not preserve space for windows from other…
Sep 10 2016, 6:05 AM
jangmarker committed R108:ef02db2fc2d5: Add an icon to the specific window settings dialog. It takes the same icon as… (authored by jangmarker).
Add an icon to the specific window settings dialog. It takes the same icon as…
Sep 10 2016, 5:56 AM

Dec 7 2015

jangmarker accepted D632: Add .clang-format file..

Nice :-)
Can we integrate that with arc?

Dec 7 2015, 6:21 PM

Nov 14 2015

jangmarker commandeered D349: [Compiler] Implemented basic code generation.
Nov 14 2015, 12:56 PM

Sep 29 2015

jangmarker added a comment to D350: Implement basics of a AST -> JS generator.

There was an issue with phabricator, it created a patch from something it shouldn't use.
Ignore Patch 3

Sep 29 2015, 10:39 AM
jangmarker updated the diff for D350: Implement basics of a AST -> JS generator.

Use correct patch

Sep 29 2015, 10:37 AM

Sep 21 2015

jangmarker triaged T760: Write CompilerPass to create the IR out of AST as High priority.
Sep 21 2015, 1:41 PM · QmlWeb
jangmarker created T847: Port QtQuick module to v2.
Sep 21 2015, 1:40 PM · QmlWeb

Sep 20 2015

jangmarker added a dependent revision for D350: Implement basics of a AST -> JS generator: D366: Finishes implementation of PureJavaScriptGenerator based on D350.
Sep 20 2015, 2:19 PM
jangmarker added a dependency for D366: Finishes implementation of PureJavaScriptGenerator based on D350: D350: Implement basics of a AST -> JS generator.
Sep 20 2015, 2:19 PM
jangmarker retitled D366: Finishes implementation of PureJavaScriptGenerator based on D350 from to Finishes implementation of PureJavaScriptGenerator based on D350.
Sep 20 2015, 2:18 PM
jangmarker reopened D350: Implement basics of a AST -> JS generator.

the commit which closed this revision was not development/qmlweb2

Sep 20 2015, 2:16 PM

Sep 15 2015

jangmarker updated the diff for D350: Implement basics of a AST -> JS generator.

[Compiler] Fix issues pointed out in review

Sep 15 2015, 7:48 PM

Sep 12 2015

jangmarker accepted D352: [Compiler] Add cmake install statement..
Sep 12 2015, 9:31 PM
jangmarker retitled D350: Implement basics of a AST -> JS generator from to Implement basics of a AST -> JS generator.
Sep 12 2015, 12:24 PM

Sep 11 2015

jangmarker accepted D343: [Compiler] Add basic types and QtQml module..

thanks

Sep 11 2015, 12:51 PM
jangmarker requested changes to D343: [Compiler] Add basic types and QtQml module..
Sep 11 2015, 12:31 PM
jangmarker accepted D342: [Compiler] Remove class LibraryClass..

thank you :-) maybe that structure will last forever :D

Sep 11 2015, 10:00 AM
jangmarker accepted D341: [Compiler] Split typesystem from objecttree in IR..
Sep 11 2015, 8:30 AM

Sep 10 2015

jangmarker added inline comments to D341: [Compiler] Split typesystem from objecttree in IR..
Sep 10 2015, 11:22 PM
jangmarker added a comment to D341: [Compiler] Split typesystem from objecttree in IR..

please fix the added inline commit, everything else is ready to go

Sep 10 2015, 11:03 PM
jangmarker added inline comments to D341: [Compiler] Split typesystem from objecttree in IR..
Sep 10 2015, 10:57 PM
jangmarker triaged T741: Make use of C++'s template classes for CompilerPass::process(T) if possible as Low priority.
Sep 10 2015, 10:24 PM · QmlWeb
jangmarker created T741: Make use of C++'s template classes for CompilerPass::process(T) if possible.
Sep 10 2015, 10:24 PM · QmlWeb

Sep 8 2015

jangmarker accepted D335: [Compiler] Implement module loading..

great :-)

Sep 8 2015, 8:53 PM · QmlWeb
jangmarker added inline comments to D335: [Compiler] Implement module loading..
Sep 8 2015, 8:18 PM · QmlWeb
jangmarker added a project to D335: [Compiler] Implement module loading.: QmlWeb.
Sep 8 2015, 8:16 PM · QmlWeb
jangmarker added inline comments to D335: [Compiler] Implement module loading..
Sep 8 2015, 3:26 PM · QmlWeb
jangmarker added a comment to D335: [Compiler] Implement module loading..

Thanks for that work and the thousand revamps, I like it's shape very much.

Sep 8 2015, 2:51 PM · QmlWeb

Jul 21 2015

jangmarker added a comment to R18:1e419ca34154: [Compiler] Make Compiler not being a singleton anymore.

It's abut testability and data encapsulation: global objects are hard to mock (i.e. change their behaviour) when testing.

Jul 21 2015, 3:25 PM
jangmarker added a comment to R18:4296398d0aee: Update README, CONTRIBUTING and LICENSE..

I think this is a good chance to unify the headers of all files to:

  • not contain a <this line describes the files purpose> line
  • check for other inconsistencies
Jul 21 2015, 12:00 PM