Details

Reviewers

jangmarker
pavelvasev

Commits

R18:34929f7f04b1: [Compiler] Split typesystem from objecttree in IR.
R18:112bd85ee45c: [Compiler] Split typesystem from objecttree in IR.

Summary

This is the first step in a revamp of the IR.
It also removes Component, makes File be a Node and rename Class to
LibraryClass.

Diff Detail

Repository

R18 QMLWeb

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

akreuzkamp updated this revision to Diff 844.Sep 10 2015, 10:14 PM

akreuzkamp retitled this revision from to [Compiler] Split typesystem from objecttree in IR..

akreuzkamp updated this object.

akreuzkamp edited the test plan for this revision. (Show Details)

akreuzkamp added reviewers: jangmarker, pavelvasev.

Repairs one test, skip one and remove the unneeded one.

jangmarker added inline comments.Sep 10 2015, 10:57 PM

src/qmljsc/CMakeLists.txt
11–12	File should be in the object tree.
src/qmljsc/ir/objecttree.h
122	please remove
src/qmljsc/ir/visitor.h
37	LibraryClass should not be visited anymore
37	same here
38–39	same for Property, Method and Signal
42	see above
42	see above
43–44	see above
src/qmljsc/moduleloading/javascriptmoduleloader.cpp
275	why do you remove this?
tests/auto/qmljsc/testir.cpp
48–49	please disable tests using QSKIP
279–280	see above

please fix the added inline commit, everything else is ready to go

src/qmljsc/ir/visitor.h
38–39	please remove those and the endVisit

Fixed, what you noted.

Fix build.

jangmarker added inline comments.Sep 10 2015, 11:22 PM

tests/auto/qmljsc/testir.cpp
299–300	I think this should still be visited?
315–316	same here

jangmarker accepted this revision.Sep 11 2015, 8:30 AM

jangmarker edited edge metadata.

This revision is now accepted and ready to land.Sep 11 2015, 8:30 AM

Closed by commit R18:34929f7f04b1: [Compiler] Split typesystem from objecttree in IR. (authored by akreuzkamp). · Explain WhySep 11 2015, 8:30 AM

Closed by commit R18:112bd85ee45c: [Compiler] Split typesystem from objecttree in IR. (authored by akreuzkamp). · Explain Why

This revision was automatically updated to reflect the committed changes.

		Path
M		src/qmljsc/CMakeLists.txt (3 lines)
M		src/qmljsc/compilerpass.h (6 lines)
M		src/qmljsc/compilerpass.cpp (2 lines)
M		src/qmljsc/compilerpasses/prettygeneratorpass.h (6 lines)
M		src/qmljsc/compilerpasses/prettygeneratorpass.cpp (11 lines)
M		src/qmljsc/ir/file.h (12 lines)
M		src/qmljsc/ir/file.cpp (20 lines)
D	M	src/qmljsc/ir/ir.h (260 lines)
D	M	src/qmljsc/ir/ir.cpp (349 lines)
A	M	src/qmljsc/ir/objecttree.h (123 lines)
A	M	src/qmljsc/ir/objecttree.cpp (110 lines)
A	M	src/qmljsc/ir/typesystem.h (138 lines)
A	M	src/qmljsc/ir/typesystem.cpp (153 lines)
M		src/qmljsc/ir/visitor.h (24 lines)
M		src/qmljsc/moduleloading/javascriptmoduleloader.cpp (8 lines)
M		src/qmljsc/moduleloading/moduleloading.cpp (2 lines)
M		tests/auto/qmljsc/testir.cpp (92 lines)
M		tests/auto/qmljsc/testmodules.cpp (2 lines)
M		tests/auto/qmljsc/testprettygeneratorpass.cpp (36 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	844	c8ee21f		Sep 10 2015, 10:14 PM	★	★
Diff 2	845	c8ee21f	Repairs one test, skip one and remove the unneeded one.	Sep 10 2015, 10:50 PM	★	★
Diff 3	846	c8ee21f	Fixed, what you noted.	Sep 10 2015, 11:11 PM	★	★
Diff 4	847	c8ee21f	Fix build.	Sep 10 2015, 11:17 PM	★	★
Diff 5	848	c8ee21f	Commit rQMLWEB34929f7f04b14131e92e44d0e7bd05d87d04e50b	Sep 11 2015, 8:33 AM	★	★
Diff 6	849	c8ee21f	Commit rQMLWEB112bd85ee45cff1a67501a1ef9e63d4514faa1a8	Sep 10 2015, 11:20 PM	★	★

[Compiler] Split typesystem from objecttree in IR.
ClosedPublic
Actions

Details

Diff Detail

Revision Contents
Changeset List

Diff 849

src/qmljsc/CMakeLists.txt

src/qmljsc/compilerpass.h

src/qmljsc/compilerpass.cpp

src/qmljsc/compilerpasses/prettygeneratorpass.h

src/qmljsc/compilerpasses/prettygeneratorpass.cpp

src/qmljsc/ir/file.h

src/qmljsc/ir/file.cpp

src/qmljsc/ir/ir.h

src/qmljsc/ir/ir.cpp

src/qmljsc/ir/objecttree.h

src/qmljsc/ir/objecttree.cpp

src/qmljsc/ir/typesystem.h

src/qmljsc/ir/typesystem.cpp

src/qmljsc/ir/visitor.h

src/qmljsc/moduleloading/javascriptmoduleloader.cpp

src/qmljsc/moduleloading/moduleloading.cpp

tests/auto/qmljsc/testir.cpp

tests/auto/qmljsc/testmodules.cpp

tests/auto/qmljsc/testprettygeneratorpass.cpp

[Compiler] Split typesystem from objecttree in IR.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 849

src/qmljsc/CMakeLists.txt

src/qmljsc/compilerpass.h

src/qmljsc/compilerpass.cpp

src/qmljsc/compilerpasses/prettygeneratorpass.h

src/qmljsc/compilerpasses/prettygeneratorpass.cpp

src/qmljsc/ir/file.h

src/qmljsc/ir/file.cpp

src/qmljsc/ir/ir.h

src/qmljsc/ir/ir.cpp

src/qmljsc/ir/objecttree.h

src/qmljsc/ir/objecttree.cpp

src/qmljsc/ir/typesystem.h

src/qmljsc/ir/typesystem.cpp

src/qmljsc/ir/visitor.h

src/qmljsc/moduleloading/javascriptmoduleloader.cpp

src/qmljsc/moduleloading/moduleloading.cpp

tests/auto/qmljsc/testir.cpp

tests/auto/qmljsc/testmodules.cpp

tests/auto/qmljsc/testprettygeneratorpass.cpp

[Compiler] Split typesystem from objecttree in IR.
ClosedPublic
Actions

Revision Contents
Changeset List