Address reviews

Hi, I'm using this change on the QML client I'm working on (which I will eventually commit on another branch).
I'm committing (and planning to continue committing) to this branch for all changes that make sense for all clients, but will keep working on the QML client only for now.

• Fix const and code style

• Fix const and code style

In D29382#662161, @mlaurent wrote:

In D29382#662136, @alessandro wrote:

The overall idea would be to move the whole communication to DDP (websocket) instead of using some REST API and some websocket API.
This way it wouldn't be necessary to poll for updates (as it's done with the REST API), since the websocket is two ways and the client can get push notifications.
Also the server is smart enough to keep track of what the client knows already, so there's no need to do things like asking for the full room list and filtering the ones the room model knows about already when joining a new room.
I don't know for sure how far back the DDP API goes, but once this implementation is done it should be good enough for most recent servers.

For sure not we will not switch back to all DDP as we switched from DDP to rest api as RC dev created it as it's faster.
We will continue to switch to RESTAPI not switching back to DDP :)

• Add few more consts

• Add few more consts

• Code style fixes

Cleaner code, also it's easier to test interactions with the server if they are separated in logical blocks this way.
With this kind of granularity it should be easier to keep up with server updates and support older server versions too.
The overall idea would be to move the whole communication to DDP (websocket) instead of using some REST API and some websocket API.
This way it wouldn't be necessary to poll for updates (as it's done with the REST API), since the websocket is two ways and the client can get push notifications.
Also the server is smart enough to keep track of what the client knows already, so there's no need to do things like asking for the full room list and filtering the ones the room model knows about already when joining a new room.
I don't know for sure how far back the DDP API goes, but once this implementation is done it should be good enough for most recent servers.

• Minor fixes: add missing newlines at end of files

• Fix merge conflicts

• Fix more tests

• Fix Room::serialize, operator<<(QDebug, Room), Room::isEqual, Room::fromJson

• Fix Room::serialize, operator<<(QDebug, Room), Room::isEqual

• Forward directChannelUserId to RoomWrapper and test
• Fix autotest helper on Windows
• Update roomtest to test Room::directChannelUserId

Commit message update (again)

Commit message update

Rebased

@kfunk the way it is now we need both colors to be set, and they should be always consistent. It was a bit worse before in this sense, now we only have some left and right margin on each message that could be moved inside the specialized delegates. Until that's not done we need both colors to be set though.

• Add layout alignment for JitsiVideoMessage

Couldn't remove the commit through arc, created a new patch with the QML changes only https://phabricator.kde.org/D27244

• Make MessageBase an Item instead of a ColumnLayout
• Make MessageBase mouse aware
• Show reaction button only when hovering on a message