Differential D28463

do not install testengine
ClosedPublic
Actions

Authored by sitter on Mar 31 2020, 10:25 AM.

Details

Reviewers
mart
apol
Commits
R242:6e39c1de5bb3: do not install testengine
Summary

by default users have to opt out of BUILD_TESTING meaning everyone would
by default build and get testengine installed even though it serves no
purpose in production. this also includes distros as I've noticed :O

do not install the engine, same as testplugin isn't getting installed.

(I am actually thinking throwing it away as a whole may make sense; it
serves no real purpose over any other engine)

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
sitter created this revision.Mar 31 2020, 10:25 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 31 2020, 10:25 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
sitter requested review of this revision.Mar 31 2020, 10:25 AM
apol added a subscriber: apol.Mar 31 2020, 12:56 PM

How is it going to be tested then?

broulik added a subscriber: broulik.Mar 31 2020, 1:00 PM

It's not used by any tests either

apol accepted this revision.Mar 31 2020, 1:01 PM
This revision is now accepted and ready to land.Mar 31 2020, 1:01 PM
Closed by commit R242:6e39c1de5bb3: do not install testengine (authored by sitter). · Explain WhyApr 6 2020, 10:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/testengine/CMakeLists.txt (3 lines)

Diff 79464

View Options

tests/testengine/CMakeLists.txt

Loading...