Deprecate KDBusConnectionPool
ClosedPublic

Authored by vkrause on Feb 23 2020, 7:49 PM.

Details

Summary

As per T12722 this is no longer needed, QDBusConnection now behaves
correctly in a multi-threaded scenario.

All uses found by lxr have either been ported already, or have patches
in review.

Diff Detail

Repository
R271 KDBusAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 22868
Build 22886: arc lint + arc unit
vkrause created this revision.Feb 23 2020, 7:49 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 23 2020, 7:49 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
vkrause requested review of this revision.Feb 23 2020, 7:49 PM
kossebau added inline comments.
src/CMakeLists.txt
45

${EXCLUDE_DEPRECATED_BEFORE_AND_AT} is not defined by default.

You want to add an option (or actually cached cmake var) in the toplevel CMakeLists.txt, lke mentioned in the docs: https://api.kde.org/ecm/module/ECMGenerateExportHeader.html
Both to document this flag, as also ensure there the variable is set (did cmake not fail for you?):

set(EXCLUDE_DEPRECATED_BEFORE_AND_AT 0 CACHE STRING "Control the range of deprecated API excluded from the build [default=0].")
vkrause updated this revision to Diff 76316.Feb 24 2020, 5:22 PM

Set EXCLUDE_DEPRECATED_BEFORE_AND_AT.

davidedmundson accepted this revision.Feb 28 2020, 3:49 PM
This revision is now accepted and ready to land.Feb 28 2020, 3:49 PM
This revision was automatically updated to reflect the committed changes.