Before loading the view, query all plasma processes and show why they're using
KUserFeedback.
Depends on D26569
davidedmundson |
Plasma |
Before loading the view, query all plasma processes and show why they're using
KUserFeedback.
Depends on D26569
Manual testing
No Linters Available |
No Unit Test Coverage |
Buildable 20988 | |
Build 21006: arc lint + arc unit |
Quite a clever solution. I like the general idea.
One major comment at the bottom, rest aren't important.
kcms/feedback/feedback.cpp | ||
---|---|---|
41 | where do you use this? | |
109 | This doesn't look right. With 2 async processes, the second one to come in will replace the first? | |
kcms/feedback/package/contents/ui/main.qml | ||
90 | unrelated to this patch. | |
144 | AFAIK we're deprecating this. Use of Kirigami.Icon would be preferred |
Very nice. It occurs to me that by showing the full list of what gets sent, we no longer need to show the details text. It's rendered obsolete by showing the actual list of what gets sent. Can we remove the description from the KCM here without touching KUSerFeedback again?