Improve Plasma user feedback introspection
ClosedPublic

Authored by apol on Fri, Jan 10, 7:13 PM.

Details

Summary

Before loading the view, query all plasma processes and show why they're using
KUserFeedback.

Depends on D26569

Test Plan

Manual testing

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
apol created this revision.Fri, Jan 10, 7:13 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFri, Jan 10, 7:13 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol requested review of this revision.Fri, Jan 10, 7:13 PM
apol updated this revision to Diff 73315.Sat, Jan 11, 11:49 PM

Async load

apol updated this revision to Diff 73641.Wed, Jan 15, 5:42 PM

rebase

Quite a clever solution. I like the general idea.

One major comment at the bottom, rest aren't important.

kcms/feedback/feedback.cpp
41

where do you use this?

109

This doesn't look right.

With 2 async processes, the second one to come in will replace the first?

kcms/feedback/package/contents/ui/main.qml
92–93

unrelated to this patch.

143

AFAIK we're deprecating this.

Use of Kirigami.Icon would be preferred

Very nice. It occurs to me that by showing the full list of what gets sent, we no longer need to show the details text. It's rendered obsolete by showing the actual list of what gets sent. Can we remove the description from the KCM here without touching KUSerFeedback again?

apol added inline comments.Wed, Jan 15, 5:58 PM
kcms/feedback/feedback.cpp
41

It's used by std::sort(m_feedbackSources.begin(), m_feedbackSources.end()...

109

No, we're using m_uses, because we need the proper integration. That's why we keep both.

apol marked an inline comment as done.Wed, Jan 15, 6:00 PM
davidedmundson accepted this revision.Wed, Jan 15, 6:02 PM
This revision is now accepted and ready to land.Wed, Jan 15, 6:02 PM
This revision was automatically updated to reflect the committed changes.